Re: [RESEND PATCH v3 3/6] charger: max14577: Configure battery-dependent settings from DTS and sysfs

Krzysztof Kozlowski
2014-08-27T13:55:31Z

On śro, 2014-08-27 at 14:50 +0100, Lee Jones wrote:
> On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:
>
> > Remove hard-coded values for:
> > - Fast Charge current,
> > - End Of Charge current,
> > - Fast Charge timer,
> > - Overvoltage Protection Threshold,
> > - Battery Constant Voltage,
> > and use DTS or sysfs to configure them. This allows using the max14577 charger
> > driver with different batteries.
> >
> > Now the charger driver requires valid configuration data from DTS. In
> > case of wrong configuration data it fails during probe. Patch adds
> > of_compatible to the charger mfd cell in MFD driver core.
> >
> > The fast charge timer is configured through sysfs entry.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Jenny Tc <jenny.tc@intel.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/mfd/max14577.c | 5 +-
>
> Hmm... not sure why I Acked this. The code looks okay, but can you
> break out the MFD changed into a separate patch please? You can add
> my Ack to the broken out patch though.

Sure, I'll split it however the compatible here in mfd_cell makes sense
only with this patch.

Best regards,
Krzysztof