Re: [RESEND PATCH v3 1/6] charger: max14577: Add support for MAX77836 charger

Lee Jones
2014-08-27T13:52:27Z

On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:

> Add support for MAX77836 charger to the max14577 driver. The MAX77836
> charger is almost the same as 14577 model except:
> - No dead-battery detection;
> - Support for special charger (like in MAX77693);
> - Support for DX over-voltage protection (like in MAX77693);
> - Lower values of charging current (two times lower current for
> slow/fast charge, much lower EOC current);
> - Slightly different values in ChgTyp field of STATUS2 register. On
> MAX14577 0x6 is reserved and 0x7 dead battery. On the MAX77836 the
> 0x6 means special charger and 0x7 is reserved. Regardless of these
> differences the driver maps them to one enum max14577_muic_charger_type.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Anton Vorontsov <anton@enomsg.org>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/power/Kconfig | 4 +-
> drivers/power/max14577_charger.c | 77 +++++++++++++++++++++++++++++-------
> include/linux/mfd/max14577-private.h | 54 ++++++++++++++++++-------

Not quite so important here, but better to break these out too. We
can arrange ourselves to that the set can go in together. Just make
sure it's bisectable.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog