From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw
Date: Wed, 27 Aug 2014 20:15:26 +0100 [thread overview]
Message-ID: <20140827191526.GS17528@sirena.org.uk> (raw)
In-Reply-To: <53FE2901.50508@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 983 bytes --]
On Wed, Aug 27, 2014 at 08:52:49PM +0200, Tomasz Figa wrote:
> On 27.08.2014 20:47, Mark Brown wrote:
> > I'm not convinced that's worth it - chances are that if anything changed
> > the mode it was a previously running Linux which will most likely be
> > doing the same things when it starts running anyway.
> The previously running Linux would have changed the opmode accidentally,
> due to hardware design of PMIC chip, which doesn't allow powering off a
> regulator in other way than setting opmode to OFF.
> If you provide the "active" opmode to that Linux, after a warm reboot it
> will be able to power on such regulator to correct opmode, without
> defaulting it incorrectly to NORMAL.
This is in the scenario where the previously running Linux changed the
mode to something other than normal and where the freshly booted Linux
can't figure out how to do that when it needs to. I'm not sure how
plausible that scenario is, or that real systems would handle it
robustly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-27 19:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 11:37 [PATCH 1/1] regulator: max77802: set opmode to normal if off is read from hw Javier Martinez Canillas
2014-08-26 15:44 ` Doug Anderson
2014-08-27 6:47 ` Yuvaraj Kumar
2014-08-27 17:51 ` Mark Brown
2014-08-27 18:32 ` Tomasz Figa
2014-08-27 18:37 ` Mark Brown
2014-08-27 18:39 ` Tomasz Figa
2014-08-27 18:47 ` Mark Brown
2014-08-27 18:52 ` Tomasz Figa
2014-08-27 19:15 ` Mark Brown [this message]
2014-08-27 19:21 ` Tomasz Figa
2014-08-27 19:44 ` Mark Brown
2014-08-27 19:58 ` Tomasz Figa
2014-08-27 20:25 ` Mark Brown
2014-08-27 20:41 ` Tomasz Figa
2014-08-27 21:03 ` Tomasz Figa
2014-08-27 22:44 ` Javier Martinez Canillas
2014-08-28 8:28 ` Mark Brown
2014-08-28 9:59 ` Javier Martinez Canillas
2014-08-28 10:01 ` Mark Brown
2014-08-27 21:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827191526.GS17528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=tomasz.figa@gmail.com \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox