From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935819AbaH0TZu (ORCPT ); Wed, 27 Aug 2014 15:25:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55762 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935181AbaH0TZs (ORCPT ); Wed, 27 Aug 2014 15:25:48 -0400 Date: Wed, 27 Aug 2014 12:25:47 -0700 From: Greg Kroah-Hartman To: Ricardo Ribalda Delgado Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE Message-ID: <20140827192547.GB9620@kroah.com> References: <1409144429-23723-1-git-send-email-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409144429-23723-1-git-send-email-ricardo.ribalda@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: > Defining the vendor and the product id should be enough to discriminate > the device. > > The reason for this patch is that there is a missmatch betweed the > modalias showed by sysfs and the modalias generated by file2alias. > > One expects the programming interface in uppercase and the other > generates it in lowercase. I don't understand, what is wrong here? Who does it in uppercase and who in lower? And does it matter? It's just a numeric value that should not be used as a string compare. > This means that some implementations modprobe will fail to load the > driver. What implementations fail to work? Shouldn't we fix the root of the problem and not just patch up all drivers to display incorrect data? And I mean incorrect, as you are changing the values here from being very specific, to being much broader. thanks, greg k-h