Re: [linuxtv-media:devel 497/499] drivers/media/platform/s5p-mfc/s5p_mfc.c:454:2-5: WARNING: Use BUG_ON

Fengguang Wu
2014-08-28T00:48:09Z

Hi Mauro,

On Wed, Aug 27, 2014 at 02:31:37PM -0300, Mauro Carvalho Chehab wrote:
> Hi Fengguang,
>
> Not sure why, but I didn't receive this e-mail (or other emails in this
> thread).

It's a manual check process rather than an email problem. The TO/CC
you see lie in the email body. The original email is sent to the
kbuild list for manual checking. We do such check for all low
confident static check warnings. Julia and Dan are actively looking at
these reports and will forward the ones that worth more attention to
the relevant people.

Thanks,
Fengguang

> Em Wed, 27 Aug 2014 19:07:45 +0200 (CEST)
> Julia Lawall <julia.lawall@lip6.fr> escreveu:
>
> > The bug_on one doesn't look like a good idea, but the returnvar one would
> > make the code a little simpler.
> >
> > julia
> >
> > On Thu, 28 Aug 2014, kbuild test robot wrote:
> >
> > > TO: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > > CC: linux-media@vger.kernel.org
> > >
> > > Hi Mauro,
> > >
> > > First bad commit (maybe != root cause):
> > >
> > > tree: git://linuxtv.org/media_tree.git devel
> > > head: 38a0731165250a0a77eff7b90ea3156d44cc7d66
> > > commit: 7155043c2d027c9c848c3d09badb5af2894ed652 [497/499] [media] enable COMPILE_TEST for media drivers
> > > :::::: branch date: 19 hours ago
> > > :::::: commit date: 19 hours ago
> > >
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:454:2-5: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:333:3-6: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:406:2-5: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:548:3-6: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:556:3-6: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:509:2-5: WARNING: Use BUG_ON
> > > >> drivers/media/platform/s5p-mfc/s5p_mfc.c:634:4-7: WARNING: Use BUG_ON
> > > --
> > > >> drivers/media/platform/davinci/vpfe_capture.c:946:5-8: Unneeded variable: "ret". Return "0" on line 951
> > >
> > > Please consider folding the attached diff :-)
> > >
> > > ---
> > > 0-DAY kernel build testing backend Open Source Technology Center
> > > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
> > >