From: Darren Hart <dvhart@infradead.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
Corentin Chary <corentin.chary@gmail.com>,
GOESSEL Guillaume <g_goessel@outlook.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [3.17 REGRESSION FIX] Revert "ideapad-laptop: Disable touchpad interface on Yoga models"
Date: Thu, 28 Aug 2014 01:13:06 -0700 [thread overview]
Message-ID: <20140828081306.GA59286@vmdeb7> (raw)
In-Reply-To: <1408960813-12237-1-git-send-email-hdegoede@redhat.com>
On Mon, Aug 25, 2014 at 12:00:13PM +0200, Hans de Goede wrote:
> I've received a bug report from a user that the touchpad control part
> of the ideapad-laptop ACPI interface does work for him on his
> "Lenovo Yoga 2 13", and that this patch causes a regression for him.
>
> Since it did not work for me when I had a "Lenovo Yoga 2 11" in my own
> hands (loaned from a friend). It seems that this is a bit of hit and miss.
>
> Since the result of having a false positive here is worse, then the minor
> annoyance of a false touchpad disabled messages being shown after suspend /
> resume on models (or is it firmware versions?) where the interface does not
> work, simply revert the patch.
>
> This reverts commit f79a901331a823ae370584b15cd39dd110b95a0a.
>
> Reported-by: GOESSEL Guillaume <g_goessel@outlook.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Queued:
git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-linus
I'll send the pull request next week after some weekend travel.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2014-08-28 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 10:00 [3.17 REGRESSION FIX] Revert "ideapad-laptop: Disable touchpad interface on Yoga models" Hans de Goede
2014-08-25 13:44 ` Josh Boyer
2014-08-26 1:38 ` Darren Hart
2014-08-28 8:13 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828081306.GA59286@vmdeb7 \
--to=dvhart@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=g_goessel@outlook.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox