From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-pm@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block
Date: Thu, 28 Aug 2014 12:52:19 +0100 [thread overview]
Message-ID: <20140828115219.GQ24579@lee--X1> (raw)
In-Reply-To: <1409152814-17302-7-git-send-email-k.kozlowski@samsung.com>
On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:
> MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver
> can be safely re-used. The patch adds MAX77836 ID to array of
> i2c_device_id.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/power/max17040_battery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/max17040_battery.c b/drivers/power/max17040_battery.c
> index 0fbac861080d..165ffe381803 100644
> --- a/drivers/power/max17040_battery.c
> +++ b/drivers/power/max17040_battery.c
> @@ -278,6 +278,7 @@ static SIMPLE_DEV_PM_OPS(max17040_pm_ops, max17040_suspend, max17040_resume);
>
> static const struct i2c_device_id max17040_id[] = {
> { "max17040", 0 },
> + { "max77836-battery", 0 },
Are you sure you want the IDs to be the same?
If they are not used, just drop them entirely.
> { }
> };
> MODULE_DEVICE_TABLE(i2c, max17040_id);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-28 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 15:20 [PATCH v4 0/8] charger/mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-08-27 15:20 ` [PATCH v4 1/8] mfd: max14577: Add defines for MAX77836 charger Krzysztof Kozlowski
2014-08-28 11:50 ` Lee Jones
2014-08-27 15:20 ` [PATCH v4 2/8] mfd: max14577: Map charger device to its own of_node Krzysztof Kozlowski
2014-08-28 11:50 ` Lee Jones
2014-08-27 15:20 ` [PATCH v4 3/8] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-08-27 15:20 ` [PATCH v4 4/8] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-08-27 15:20 ` [PATCH v4 5/8] charger: max14577: Configure battery-dependent settings from DTS and sysfs Krzysztof Kozlowski
2014-08-27 15:20 ` [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block Krzysztof Kozlowski
2014-08-28 11:52 ` Lee Jones [this message]
2014-08-28 12:28 ` Krzysztof Kozlowski
2014-08-28 12:42 ` Lee Jones
2014-08-27 15:20 ` [PATCH v4 7/8] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2014-08-27 15:20 ` [PATCH v4 8/8] Documentation: charger: max14577: Document exported sysfs entry Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828115219.GQ24579@lee--X1 \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox