From: David Miller <davem@davemloft.net>
To: hock.leong.kweh@intel.com
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, boon.leong.ong@intel.com
Subject: Re: [PATCH 1/4] net: stmmac: enhance to support multiple device instances
Date: Fri, 29 Aug 2014 20:06:23 -0700 (PDT) [thread overview]
Message-ID: <20140829.200623.1931173830496862001.davem@davemloft.net> (raw)
In-Reply-To: <cf29eb9e793cf67b99b455f3a4a55e7aca5d826c.1409123378.git.hock.leong.kweh@intel.com>
From: Kweh Hock Leong <hock.leong.kweh@intel.com>
Date: Wed, 27 Aug 2014 18:32:26 +0800
> @@ -26,27 +26,22 @@
> #include <linux/pci.h>
> #include "stmmac.h"
>
> -static struct plat_stmmacenet_data plat_dat;
> -static struct stmmac_mdio_bus_data mdio_data;
> -static struct stmmac_dma_cfg dma_cfg;
> +static int instance_id = 1;
Don't do this instance stuff. Instead pull in some identifier that
can come from elsewhere.
> + plat_dat->mdio_bus_data = devm_kzalloc(&pdev->dev,
> + sizeof(*plat_dat->mdio_bus_data),
> + GFP_KERNEL);
This is not indented properly.
On the second and subsequent lines of a multi-line function call,
the lines should start exactly at the first column after the openning
parenthesis of the first line.
You must use the correct number of TAB and SPACE characters necessary
to do so. Generally speaking, if you are indenting using only TAB
characters, odds are you are doing it wrong.
Please audit for, and fix this, in your entire patch series.
next prev parent reply other threads:[~2014-08-30 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 10:32 [PATCH 0/4] net: stmmac: Enable Intel Quark SoC X1000 Ethernet support Kweh Hock Leong
2014-08-27 10:32 ` [PATCH 1/4] net: stmmac: enhance to support multiple device instances Kweh Hock Leong
2014-08-30 3:06 ` David Miller [this message]
2014-08-30 3:48 ` Kweh, Hock Leong
2014-09-08 3:10 ` Kweh, Hock Leong
2014-08-27 10:32 ` [PATCH 2/4] net: stmmac: better code manageability with platform data struct Kweh Hock Leong
2014-08-27 10:32 ` [PATCH 3/4] net: stmmac: add support for Intel Quark X1000 Kweh Hock Leong
2014-08-27 10:32 ` [PATCH 4/4] net: stmmac: add MSI " Kweh Hock Leong
2014-08-27 12:52 ` [PATCH 0/4] net: stmmac: Enable Intel Quark SoC X1000 Ethernet support Giuseppe CAVALLARO
2014-08-29 1:28 ` Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829.200623.1931173830496862001.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boon.leong.ong@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).