From: Matthias Beyer <mail@beyermatthias.de>
To: Andrew Plummer <plummer574@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: LeakyBucket: format kernel-docs
Date: Sat, 30 Aug 2014 10:04:12 +0200 [thread overview]
Message-ID: <20140830080412.GA4509@fu.3gs> (raw)
In-Reply-To: <1409345416-16408-1-git-send-email-plummer574@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5185 bytes --]
On 29-08-2014 21:50:16, Andrew Plummer wrote:
> Remove insignificant spaces before tabs in comments.
>
> Signed-off-by: Andrew Plummer <plummer574@gmail.com>
> ---
> drivers/staging/bcm/LeakyBucket.c | 81 ++++++++++++++++-----------------------
> 1 file changed, 33 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/staging/bcm/LeakyBucket.c b/drivers/staging/bcm/LeakyBucket.c
> index 8c4030d..d6b55f9 100644
> --- a/drivers/staging/bcm/LeakyBucket.c
> +++ b/drivers/staging/bcm/LeakyBucket.c
> @@ -1,20 +1,16 @@
> /**********************************************************************
> -* LEAKYBUCKET.C
> +* LEAKYBUCKET.C
> * This file contains the routines related to Leaky Bucket Algorithm.
> ***********************************************************************/
> #include "headers.h"
>
> -/*********************************************************************
> -* Function - UpdateTokenCount()
> -*
> -* Description - This function calculates the token count for each
> -* channel and updates the same in Adapter strucuture.
> -*
> -* Parameters - Adapter: Pointer to the Adapter structure.
> -*
> -* Returns - None
> -**********************************************************************/
> -
> +/**
> + * UpdateTokenCount() - Calculates the token count for each channel
> + * and updates the same in Adapter structure
> + * @Adapter: Pointer to the Adapter structure.
> + *
> + * Return: None
> + */
> static VOID UpdateTokenCount(register struct bcm_mini_adapter *Adapter)
> {
> ULONG liCurrentTime;
> @@ -59,20 +55,16 @@ static VOID UpdateTokenCount(register struct bcm_mini_adapter *Adapter)
> }
>
>
> -/*********************************************************************
> -* Function - IsPacketAllowedForFlow()
> -*
> -* Description - This function checks whether the given packet from the
> -* specified queue can be allowed for transmission by
> -* checking the token count.
> -*
> -* Parameters - Adapter : Pointer to the Adpater structure.
> -* - iQIndex : The queue Identifier.
> -* - ulPacketLength: Number of bytes to be transmitted.
> -*
> -* Returns - The number of bytes allowed for transmission.
> -*
> -***********************************************************************/
> +/**
> + * IsPacketAllowedForFlow() - This function checks whether the given
> + * packet from the specified queue can be allowed for transmission by
> + * checking the token count.
> + * @Adapter: Pointer to the Adpater structure.
> + * @iQIndex: The queue Identifier.
> + * @ulPacketLength: Number of bytes to be transmitted.
> + *
> + * Returns: The number of bytes allowed for transmission.
> + */
> static ULONG GetSFTokenCount(struct bcm_mini_adapter *Adapter, struct bcm_packet_info *psSF)
> {
> BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, TOKEN_COUNTS, DBG_LVL_ALL,
> @@ -256,18 +248,14 @@ static void send_control_packet(struct bcm_mini_adapter *ad,
> }
> }
>
> -/************************************************************************
> -* Function - CheckAndSendPacketFromIndex()
> -*
> -* Description - This function dequeues the data/control packet from the
> -* specified queue for transmission.
> -*
> -* Parameters - Adapter : Pointer to the driver control structure.
> -* - iQIndex : The queue Identifier.
> -*
> -* Returns - None.
> -*
> -****************************************************************************/
> +/**
> + * CheckAndSendPacketFromIndex() - This function dequeues the
> + * data/control packet from the specified queue for transmission.
> + * @Adapter: Pointer to the driver control structure.
> + * @iQIndex: The queue Identifier.
> + *
> + * Returns: None.
> + */
> static VOID CheckAndSendPacketFromIndex(struct bcm_mini_adapter *Adapter,
> struct bcm_packet_info *psSF)
> {
> @@ -284,16 +272,13 @@ static VOID CheckAndSendPacketFromIndex(struct bcm_mini_adapter *Adapter,
> }
>
>
> -/*******************************************************************
> -* Function - transmit_packets()
> -*
> -* Description - This function transmits the packets from different
> -* queues, if free descriptors are available on target.
> -*
> -* Parameters - Adapter: Pointer to the Adapter structure.
> -*
> -* Returns - None.
> -********************************************************************/
> +/**
> + * transmit_packets() - This function transmits the packets from
> + * different queues, if free descriptors are available on target.
> + * @Adapter: Pointer to the Adapter structure.
> + *
> + * Returns: None.
> + */
> VOID transmit_packets(struct bcm_mini_adapter *Adapter)
> {
> UINT uiPrevTotalCount = 0;
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Reviewed-by: Matthias Beyer <mail@beyermatthias.de>
--
Mit freundlichen Grüßen,
Kind regards,
Matthias Beyer
Proudly sent with mutt.
Happily signed with gnupg.
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-30 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 20:50 [PATCH] Staging: bcm: LeakyBucket: format kernel-docs Andrew Plummer
2014-08-30 8:04 ` Matthias Beyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830080412.GA4509@fu.3gs \
--to=mail@beyermatthias.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plummer574@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox