From: Dan Carpenter <dan.carpenter@oracle.com>
To: Janet Liu <jianhua.ljh@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 1/4] staging:lustre:lnet: lib-md.c make line not over 80 characters
Date: Sat, 30 Aug 2014 13:58:19 +0300 [thread overview]
Message-ID: <20140830105819.GH5071@mwanda> (raw)
In-Reply-To: <1409381575-2211-1-git-send-email-jianhua.ljh@gmail.com>
On Sat, Aug 30, 2014 at 02:52:55PM +0800, Janet Liu wrote:
> @@ -121,7 +123,7 @@ lnet_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int unlink)
>
> lmd->md_length = total_length;
>
> - if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /* max size used */
> + if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /*max size used*/
Better to go over the 80 character limit than to mangle it this way.
regards,
dan carpenter
prev parent reply other threads:[~2014-08-30 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 6:52 [PATCHv1 1/4] staging:lustre:lnet: lib-md.c make line not over 80 characters Janet Liu
2014-08-30 6:56 ` [PATCHv1 2/4] staging:lustre:lnet: lib-md.c delete space before '(' for code style Janet Liu
2014-08-30 6:57 ` [PATCHv1 3/4] staging:lustre:lnet: lib-md.c erase C99 // comments Janet Liu
2014-08-30 6:59 ` [PATCHv1 4/4] staging:lustre:lnet lib-md.c erase space before ')' for code style Janet Liu
2014-08-30 19:22 ` [PATCHv1 3/4] staging:lustre:lnet: lib-md.c erase C99 // comments Greg KH
2014-08-30 19:20 ` [PATCHv1 2/4] staging:lustre:lnet: lib-md.c delete space before '(' for code style Greg KH
2014-08-30 10:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830105819.GH5071@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jianhua.ljh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox