From: Greg KH <gregkh@linuxfoundation.org>
To: Hema Prathaban <hemaklnce@gmail.com>
Cc: devel@driverdev.osuosl.org, oleg.drokin@intel.com,
andreas.dilger@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required
Date: Sat, 30 Aug 2014 11:56:20 -0700 [thread overview]
Message-ID: <20140830185620.GA7455@kroah.com> (raw)
In-Reply-To: <20140821132907.GA4118@hema-Inspiron-3520>
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: Required space after " '+' ',' '=' '(' ' if' "
>
> Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
> ---
> drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/events.c | 4 ++--
> drivers/staging/lustre/lustre/ptlrpc/import.c | 8 ++++----
> drivers/staging/lustre/lustre/ptlrpc/llog_client.c | 16 ++++++++--------
> drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c | 6 +++---
> drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/sec_config.c | 6 +++---
> drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 2 +-
> drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
> 9 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index 8fa9b71..a327d19 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/client.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
> @@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct ptlrpc_request *req,
> at = &req->rq_import->imp_at;
>
> /* Network latency is total time less server processing time */
> - nl = max_t(int, now - req->rq_sent - service_time, 0) +1/*st rounding*/;
> + nl = max_t(int, now - req->rq_sent - service_time, 0) + 1/*st rounding*/;
> if (service_time > now - req->rq_sent + 3 /* bz16408 */)
> CWARN("Reported service time %u > total measured time "
> CFS_DURATION_T"\n", service_time,
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c b/drivers/staging/lustre/lustre/ptlrpc/events.c
> index c3ec21d..9f5af45 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/events.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
> @@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
> if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
> ev->status = -EIO;
>
> - if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
> + if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2, CFS_FAIL_ONCE))
You obviously did not compile this code as it breaks the build :(
Please _always_ test build your patches, don't force others to find
errors like this, it's a huge waste of time on my end when it happens...
greg k-h
prev parent reply other threads:[~2014-08-30 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 13:29 [PATCH] staging: lustre: lustre: ptlrpc: Fix space required Hema Prathaban
2014-08-30 18:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830185620.GA7455@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=hemaklnce@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox