public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Oliveira <cmroliv@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h
Date: Sat, 30 Aug 2014 13:41:41 -0700	[thread overview]
Message-ID: <20140830204141.GD16168@kroah.com> (raw)
In-Reply-To: <1408703632-32286-1-git-send-email-cmroliv@gmail.com>

On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote:
> Convert all rtw_proc_xxx references to rtw_sys_xxx in file
> include/rtw_debug.h

That's interesting, but:

> 
> Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/rtw_debug.h |  227 +++++++++++--------------
>  1 file changed, 98 insertions(+), 129 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h b/drivers/staging/rtl8188eu/include/rtw_debug.h
> index a38616e..aa0f46a 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_debug.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
> @@ -87,7 +87,7 @@ extern u32 GlobalDebugLevel;
>  #define MSG_88E(...)							\
>  	do {								\
>  		if (_drv_err_ <= GlobalDebugLevel)			\
> -			pr_info(DRIVER_PREFIX __VA_ARGS__);			\
> +			pr_info(DRIVER_PREFIX __VA_ARGS__);		\

How does this change relate to what you said you were going to do above?

confused,

greg k-h

  reply	other threads:[~2014-08-30 20:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 10:32 [PATCH 1/4] staging: rtl8188eu: os_intfs.c Miguel Oliveira
2014-08-22 10:33 ` [PATCH 2/4] staging: rtl8188eu: rtw_debug.c Miguel Oliveira
2014-08-30 20:40   ` Greg KH
2014-08-22 10:33 ` [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c Miguel Oliveira
2014-08-30 20:41   ` Greg KH
2014-08-30 21:22     ` Miguel Oliveira
2014-08-30 22:05       ` Greg KH
2014-09-01  9:54       ` Dan Carpenter
2014-09-01 11:55         ` Miguel Oliveira
2014-08-22 10:33 ` [PATCH 4/4] staging: rtl8188eu: rtw_debug.h Miguel Oliveira
2014-08-30 20:41   ` Greg KH [this message]
2014-08-30 21:24     ` Miguel Oliveira
2014-08-30 20:40 ` [PATCH 1/4] staging: rtl8188eu: os_intfs.c Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140830204141.GD16168@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=cmroliv@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox