From: Greg KH <gregkh@linuxfoundation.org>
To: Ramon Fried <ramon.fried@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings
Date: Sat, 30 Aug 2014 14:01:28 -0700 [thread overview]
Message-ID: <20140830210128.GA11560@kroah.com> (raw)
In-Reply-To: <20140830195432.GA29429@gmail.com>
On Sat, Aug 30, 2014 at 10:54:32PM +0300, Ramon Fried wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: Possible unnecessary 'out of memory' message
> #146: FILE: ./xlr_net.c:146:
> + if (!skb) {
> + pr_err("SKB allocation failed\n");
>
> WARNING: Missing a blank line after declarations
> #1107: FILE: ./xlr_net.c:1107:
> + struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> + unregister_netdev(priv->ndev);
> >From 27b58d9b1d39ab99bf6022b82ac9e602621b2822 Mon Sep 17 00:00:00 2001
> From: Ramon Fried <ramon.fried@gmail.com>
> Date: Sat, 30 Aug 2014 22:26:11 +0300
> Subject: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
WHy did you not put the information above in the changelog area here?
And why send a patch as an attachment, I can't do much of anything with
that :(
Also, please use the scripts/get_maintainer.pl tool to determine who and
what mailing lists to cc: for a patch.
Please fix this up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-30 21:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 19:54 [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings Ramon Fried
2014-08-30 21:01 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-31 0:16 Ramon Fried
2014-08-31 0:32 ` Greg Kroah-Hartman
2014-08-31 7:24 Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830210128.GA11560@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramon.fried@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox