From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Helge Deller <deller@gmx.de>,
Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH v3 1/5] seq_file: provide an analogue of print_hex_dump()
Date: Sat, 30 Aug 2014 23:54:07 +0100 [thread overview]
Message-ID: <20140830225407.GF7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1408957395-404-2-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, Aug 25, 2014 at 12:03:11PM +0300, Andy Shevchenko wrote:
> The new seq_hex_dump() is a complete analogue of print_hex_dump().
>
> We have few users of this functionality already. It allows to reduce their
> codebase.
I really don't like the stack footprint.
> + unsigned char linebuf[32 * 3 + 2 + 32 + 1];
... and extra copying for no good reason. Why not check that we have
enough space in buffer and generate directly into it? See what e.g.
seq_escape() is doing...
next prev parent reply other threads:[~2014-08-30 22:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 9:03 [PATCH v3 0/5] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
2014-08-25 9:03 ` [PATCH v3 1/5] seq_file: provide an analogue of print_hex_dump() Andy Shevchenko
2014-08-30 22:54 ` Al Viro [this message]
2014-09-01 8:36 ` Andy Shevchenko
2014-09-01 8:58 ` Geert Uytterhoeven
2014-09-01 9:09 ` Andy Shevchenko
2014-09-01 9:25 ` Geert Uytterhoeven
2014-09-01 10:15 ` Andy Shevchenko
2014-09-01 10:59 ` Geert Uytterhoeven
2014-09-01 11:33 ` Andy Shevchenko
2014-09-01 11:49 ` Geert Uytterhoeven
2014-09-01 11:53 ` Andy Shevchenko
2014-08-25 9:03 ` [PATCH v3 2/5] saa7164: convert to seq_hex_dump() Andy Shevchenko
2014-08-25 9:03 ` [PATCH v3 3/5] crypto: qat - use seq_hex_dump() to dump buffers Andy Shevchenko
2014-08-25 9:03 ` [PATCH v3 4/5] parisc: " Andy Shevchenko
2014-08-26 19:36 ` Helge Deller
2014-08-25 9:03 ` [PATCH v3 5/5] [S390] zcrypt: " Andy Shevchenko
2014-08-27 13:26 ` Ingo Tuchscherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830225407.GF7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andriy.shevchenko@linux.intel.com \
--cc=deller@gmx.de \
--cc=herbert@gondor.apana.org.au \
--cc=ingo.tuchscherer@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=marex@denx.de \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox