From: Greg KH <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Arjan van de Ven <arjan@linux.intel.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
falcon@meizu.com, tiwai@suse.de, linux-kernel@vger.kernel.org,
oleg@redhat.com, akpm@linux-foundation.org,
penguin-kernel@i-love.sakura.ne.jp,
joseph.salisbury@canonical.com, bpoirier@suse.de,
"Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [RFC v1 0/3] driver-core: add asynch module loading support
Date: Sun, 31 Aug 2014 15:15:34 -0700 [thread overview]
Message-ID: <20140831221534.GA18064@kroah.com> (raw)
In-Reply-To: <20140831215313.GA28690@mtj.dyndns.org>
On Sun, Aug 31, 2014 at 05:53:13PM -0400, Tejun Heo wrote:
> Hello, Greg.
>
> On Sun, Aug 31, 2014 at 01:40:35PM -0700, Greg KH wrote:
> > > Right, all (well almost all) I wanted is for individual drivers to declare
> > > their probe() functions asynchronous and driver core scheduling async attach
> > > and properly handle failures from it.
> >
> > Yes, that's what I want as well.
> >
> > Luis, care to redo the patches in this way? It should be a lot simpler
> > (no messing around with init levels and linker fun...)
>
> I don't think binding that switch to the driver is gonna work. This
> is mainly about the behavior expected by the entity which initiated
> module loading not about specific drivers. I'm fairly certain that
> there are userland scripts which depend on synchronous device probing
> on module loading, especially for storage devices, so we can't simply
> mark, say, libata as needing async probing and do it always
> asynchronously.
For the use cases we have today, it would work. We have a few drivers
that take a _long_ time in their probe callback, and they need to be
made async for various reasons (modprobe timeout killer, touchscreen
init sequence stalling boot, etc.)
I'm not saying to mark drivers that require synchronous probing with
this flag, that would be broken and wrong.
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-31 22:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 9:03 [RFC v1 0/3] driver-core: add asynch module loading support Luis R. Rodriguez
2014-08-31 9:03 ` [RFC v1 1/3] driver-core: split module_init() and module_exit() Luis R. Rodriguez
2014-08-31 9:03 ` [RFC v1 2/3] async: move synchronous caller into a helper Luis R. Rodriguez
2014-08-31 9:03 ` [RFC v1 3/3] async: add driver asynch levels Luis R. Rodriguez
2014-08-31 10:13 ` [RFC v1 0/3] driver-core: add asynch module loading support Tejun Heo
2014-08-31 11:02 ` Tejun Heo
2014-08-31 11:05 ` Tejun Heo
2014-08-31 17:52 ` Dmitry Torokhov
2014-08-31 19:26 ` Arjan van de Ven
2014-08-31 20:11 ` Dmitry Torokhov
2014-08-31 11:25 ` David Herrmann
2014-08-31 11:38 ` Tejun Heo
2014-08-31 18:28 ` Dmitry Torokhov
2014-08-31 22:02 ` Tejun Heo
2014-08-31 23:06 ` Dmitry Torokhov
2014-08-31 23:40 ` Tejun Heo
2014-08-31 14:44 ` Arjan van de Ven
2014-08-31 17:50 ` Dmitry Torokhov
2014-08-31 19:24 ` Arjan van de Ven
2014-08-31 19:31 ` Greg KH
2014-08-31 20:14 ` Dmitry Torokhov
2014-08-31 20:40 ` Greg KH
2014-08-31 21:53 ` Tejun Heo
2014-08-31 22:15 ` Greg KH [this message]
2014-08-31 22:53 ` Tejun Heo
2014-08-31 23:20 ` Arjan van de Ven
2014-08-31 23:29 ` Tejun Heo
2014-08-31 22:51 ` Dmitry Torokhov
2014-08-31 23:03 ` Tejun Heo
2014-09-04 21:21 ` Luis R. Rodriguez
2014-09-04 21:52 ` Greg KH
2014-08-31 16:41 ` Greg KH
[not found] <99jhsb6abtsilpt3j5nu991b.1409513632114@email.android.com>
2014-08-31 22:32 ` Arjan van de Ven
2014-08-31 22:45 ` Dmitry Torokhov
2014-08-31 22:48 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140831221534.GA18064@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=bpoirier@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=falcon@meizu.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=oleg@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox