Re: [PATCH v2 2/3] iio: accel: BMC150: fix issues when CONFIG_PM_RUNTIME is not set

Jonathan Cameron
2014-08-30T10:45:38Z

On 29/08/14 09:38, Laurentiu Palcu wrote:
> When CONFIG_PM_RUNTIME is not set, the following issues are seen:
> * warning message at compilation time:
> warning: 'bmc150_accel_get_startup_times' defined but not used [-Wunused-function]
> * bmc150_accel_set_power_state() will always fail and reading the
> accelerometer data is impossible;
Why? Would be good to have an explanation here...

If on is true then it will call pm_runtime_get_sync which calls __pm_runtime_resume
which when CONFIG_PM_RUNTIME is not defined returns 1 which is not an error.

In the on = false case it calls pm_runtime_put_autosuspend which calls __pm_runtime_suspend
which returns -ENOSYS and gives our error.

I'll add something to the patch description to this effect.
>
> This commit fixes these.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
> drivers/iio/accel/bmc150-accel.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
> index ccb6cf8..0e6566a 100644
> --- a/drivers/iio/accel/bmc150-accel.c
> +++ b/drivers/iio/accel/bmc150-accel.c
> @@ -499,6 +499,7 @@ static int bmc150_accel_get_bw(struct bmc150_accel_data *data, int *val,
> return -EINVAL;
> }
>
> +#ifdef CONFIG_PM_RUNTIME
> static int bmc150_accel_get_startup_times(struct bmc150_accel_data *data)
> {
> int i;
> @@ -529,6 +530,12 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
>
> return 0;
> }
> +#else
> +static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
> +{
> + return 0;
> +}
> +#endif
>
> static int bmc150_accel_set_scale(struct bmc150_accel_data *data, int val)
> {
>