Re: [PATCH v1 1/5] mfd: lpc_sch: reduce duplicate code

Andy Shevchenko
2014-09-01T14:00:18Z

On Mon, 2014-09-01 at 14:46 +0100, Lee Jones wrote:

[]

> > Okay, what about 1 — IP is present and we have no error, 0 — no ip, no
> > error, -err — error that should be returned, would it work for you?
>
> I would suggest -E<error_message> for messages to be passed back, 0
> for 'everything found and correct' and >0 (#defined of course) for any
> local messages you wish to pass 'IP not found', etc.
>
> > > #define LCP_SKIP_RESOURCE /* Seems resonable? */

Okay, makes sense. Will do this in v2.

--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy