From: Christoph Hellwig <hch@lst.de>
To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Robert Elliott <Elliott@hp.com>,
yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
"Ewan D. Milne" <emilne@redhat.com>,
Doug Gilbert <dgilbert@interlog.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte
Date: Mon, 1 Sep 2014 17:15:31 +0200 [thread overview]
Message-ID: <20140901151531.GA5136@lst.de> (raw)
In-Reply-To: <20140901123327.597.39622.stgit@yuno-kbuild.novalocal>
On Mon, Sep 01, 2014 at 12:33:28PM +0000, Yoshihiro YUNOMAE wrote:
> For getting driver byte, host byte, msg byte, and status byte, macros are
> implemented in scsi/scsi.h, so we use it.
As mentioned about three times in various previous scsi logging discussions
this is entirely wrong and breaks decoding binary trace buffers.
NAK.
next prev parent reply other threads:[~2014-09-01 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 12:33 [ PATCH -logging 0/3] scsi/trace: Delete duplicated decoders Yoshihiro YUNOMAE
2014-09-01 12:33 ` [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte Yoshihiro YUNOMAE
2014-09-01 15:15 ` Christoph Hellwig [this message]
2014-09-02 6:03 ` Yoshihiro YUNOMAE
2014-09-01 12:33 ` [PATCH 2/3] scsi/trace: Delete duplicated decoders of hostbyte and driverbyte Yoshihiro YUNOMAE
2014-09-01 12:33 ` [PATCH 3/3] scsi/trace: Delete a duplicated decoder of SCSI command Yoshihiro YUNOMAE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901151531.GA5136@lst.de \
--to=hch@lst.de \
--cc=Elliott@hp.com \
--cc=JBottomley@parallels.com \
--cc=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=yoshihiro.yunomae.ez@hitachi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox