From: Al Viro <viro@ZenIV.linux.org.uk>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Evgeniy Dushistov <dushistov@mail.ru>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] ufs: fix deadlocks after mutex merge
Date: Tue, 2 Sep 2014 00:13:07 +0100 [thread overview]
Message-ID: <20140901231306.GL7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140901230835.GK7996@ZenIV.linux.org.uk>
On Tue, Sep 02, 2014 at 12:08:35AM +0100, Al Viro wrote:
> Your commit message makes no sense - ufs_evict_inode() is *never* called
> with that lock held, for one thing. I agree that "ufs: sb mutex merge +
> mutex_destroy" was been badly broken and apparently never tested, though -
> the bugs are real.
>
> Please, write a saner commit message; what happens is that
> ufs_{new,free}_inode() take the damn lock themselves these days, so
> their caller shouldn't do that.
PS: after rereading your mail, I see what you meant to say, but it really
wasn't clear enough. The crucial part is that the lock is *always* taken
by free/new, not that some of the callers take it and some do not.
next prev parent reply other threads:[~2014-09-01 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 22:30 [PATCH] ufs: fix deadlocks after mutex merge Alexey Khoroshilov
2014-09-01 23:08 ` Al Viro
2014-09-01 23:13 ` Al Viro [this message]
2014-09-02 7:40 ` [PATCH v2] ufs: fix deadlocks introduced by sb " Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901231306.GL7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dushistov@mail.ru \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox