From: Peter Zijlstra <peterz@infradead.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: Tree for Aug 23
Date: Tue, 2 Sep 2014 11:55:53 +0200 [thread overview]
Message-ID: <20140902095553.GE31157@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <20140902094016.GD31157@worktop.ger.corp.intel.com>
On Tue, Sep 02, 2014 at 11:40:16AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 01, 2014 at 09:04:38PM +0200, Peter Zijlstra wrote:
> > On Mon, Sep 01, 2014 at 09:46:42AM -0700, Guenter Roeck wrote:
> > > Yes, the problem is still seen in next-140829. See qemu test results at
> > > http://server.roeck-us.net:8010/builders.
> > >
> > > I provided sparc64 images at http://server.roeck-us.net/qemu/sparc64/.
> > > The README file includes instructions on how to run the image in qemu
> > > and how to build a kernel.
> > >
> > > I can do the same for mips and mips64 if needed; let me know.
> >
> > Thanks, that's enough to get started.
>
> This makes sparc64 go again, silly oversight indeed.
>
The same for mips. Can you either provide the mips image or verify this works?
---
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index 476fe3b..b3dd612 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -93,7 +93,7 @@ static __inline__ int atomic_##op##_return(int i, atomic_t * v) \
" " #asm_op " %0, %1, %3 \n" \
" sc %0, %2 \n" \
" beqzl %0, 1b \n" \
- " addu %0, %1, %3 \n" \
+ " " #asm_op " %0, %1, %3 \n" \
" .set mips0 \n" \
: "=&r" (result), "=&r" (temp), "+m" (v->counter) \
: "Ir" (i)); \
next prev parent reply other threads:[~2014-09-02 9:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 22:04 linux-next: Tree for Aug 23 Stephen Rothwell
2014-08-25 4:57 ` Guenter Roeck
2014-09-01 15:58 ` Peter Zijlstra
2014-09-01 16:46 ` Guenter Roeck
2014-09-01 19:04 ` Peter Zijlstra
2014-09-02 9:40 ` Peter Zijlstra
2014-09-02 9:55 ` Peter Zijlstra [this message]
2014-09-02 19:04 ` Guenter Roeck
2014-09-02 20:21 ` Peter Zijlstra
2014-09-02 23:50 ` Guenter Roeck
2014-09-10 17:31 ` [tip:locking/arch] locking, mips: Fix atomics tip-bot for Peter Zijlstra
2014-09-02 17:59 ` linux-next: Tree for Aug 23 Guenter Roeck
2014-09-10 17:31 ` [tip:locking/arch] locking, sparc64: Fix atomics tip-bot for Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2024-08-23 3:37 linux-next: Tree for Aug 23 Stephen Rothwell
2023-08-23 6:14 Stephen Rothwell
2022-08-23 5:26 Stephen Rothwell
2021-08-23 10:26 Stephen Rothwell
2019-08-23 9:26 Stephen Rothwell
2019-08-24 2:37 ` John Hubbard
2018-08-23 3:32 Stephen Rothwell
2017-08-23 7:09 Stephen Rothwell
2016-08-23 4:55 Stephen Rothwell
2012-08-23 5:22 Stephen Rothwell
2011-08-23 6:04 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902095553.GE31157@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox