From: Jean-Francois Moine <moinejf@free.fr>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: <broonie@kernel.org>, <perex@perex.cz>, <lgirdwood@gmail.com>,
<tiwai@suse.de>, <andrew@lunn.ch>,
<kuninori.morimoto.gx@renesas.com>, <jsarha@ti.com>,
<devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.
Date: Tue, 2 Sep 2014 12:44:38 +0200 [thread overview]
Message-ID: <20140902124438.36da4b85@armhf> (raw)
In-Reply-To: <1409649969-15759-4-git-send-email-Li.Xiubo@freescale.com>
On Tue, 2 Sep 2014 17:26:08 +0800
Xiubo Li <Li.Xiubo@freescale.com> wrote:
> @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct device_node *node,
> dai_props->codec_dai.sysclk);
>
> /*
> - * soc_bind_dai_link() will check cpu name
> - * after of_node matching if dai_link has cpu_dai_name.
> - * but, it will never match if name was created by fmt_single_name()
> - * remove cpu_dai_name to escape name matching.
> - * see
> + * In soc_bind_dai_link() will check cpu name after
> + * of_node matching if dai_link has cpu_dai_name.
> + * but, it will never match if name was created by
> + * fmt_single_name() remove cpu_dai_name to escape
> + * name matching. Please see:
> * fmt_single_name()
> * fmt_multiple_name()
> */
The patch done by Kuninori, setting the cpu_dai_name to NULL in all
cases, does not work. This sequence should be replaced where is was
previously.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2014-09-02 10:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 9:26 [PATCHv2 0/4] simple-card: simplify the code Xiubo Li
2014-09-02 9:26 ` [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to " Xiubo Li
2014-09-02 10:21 ` Varka Bhadram
2014-09-02 10:38 ` Jean-Francois Moine
2014-09-02 10:42 ` Varka Bhadram
2014-09-02 11:04 ` Takashi Iwai
2014-09-02 11:09 ` Jean-Francois Moine
2014-09-02 11:32 ` Jyri Sarha
2014-09-02 11:10 ` Jyri Sarha
2014-09-03 2:37 ` Li.Xiubo
2014-09-03 8:36 ` Jyri Sarha
2014-09-03 8:39 ` Li.Xiubo
2014-09-03 0:26 ` [alsa-devel] " Kuninori Morimoto
2014-09-03 2:21 ` Li.Xiubo
2014-09-03 3:36 ` Kuninori Morimoto
2014-09-03 3:41 ` Li.Xiubo
2014-09-03 3:37 ` Li.Xiubo
2014-09-03 4:13 ` Kuninori Morimoto
2014-09-03 5:33 ` Li.Xiubo
2014-09-03 6:48 ` Jean-Francois Moine
2014-09-02 9:26 ` [PATCHv2 2/4] ASoC: simple-card: Merge single and muti DAI link(s) code Xiubo Li
2014-09-02 9:26 ` [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card Xiubo Li
2014-09-02 10:44 ` Jean-Francois Moine [this message]
2014-09-03 1:55 ` Li.Xiubo
2014-09-03 2:14 ` [alsa-devel] " Kuninori Morimoto
2014-09-03 2:24 ` Li.Xiubo
2014-09-02 9:26 ` [PATCHv2 4/4] ASoC: simple-card: binding: update binding to support the new style Xiubo Li
2014-09-02 10:41 ` Jean-Francois Moine
2014-09-03 1:54 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140902124438.36da4b85@armhf \
--to=moinejf@free.fr \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox