Re: [PATCH] Next branch: authgss: authgss.c: Fix warnings for uninitizlized variable expire

Boaz Harrosh
2014-09-02T16:05:54Z

On 09/02/2014 05:17 PM, Bruce Fields wrote:
> On Tue, Sep 02, 2014 at 04:59:45PM +0300, Boaz Harrosh wrote:
>> uninitialized_var was made to be a friend not an enemy, in the face of real
>> ugliness it is the best we can do. And that is what it should communicate to
>> everyone. Why has it become everyone's favorite blasphemy I do not know.
>
> Not personally claiming it should never be used, just that this
> particular case is kind of extreme, since unless I'm missing a real
> compilication it's basically just:
>
> if (ctx)
> assign to expire
> ...
> if (ctx)
> use expire
>
> A compiler wouldn't have to be that smart to actually prove to itself
> that expire is initialized at the last step, and that it's not only
> failing to do that but actually flagging it as possibly unitialized is
> weird.

Actually that is a complicated case for a compiler. Because of the two
different scopes. I think it only optimizes that on higher optimization
values. Cross scope analysis is not done at parsing time but more on
code generation time, the "warning" is more of the former phase.

Perhaps change the code, if possible, so the assign and use of "expire"
is under the last if (or the first)? That would be also easier on the
reader.

BTW: You are most probably right though, because here I do not have this
problem. I guess it is the case of an old compiler with a certain
compilation environment.

Thanks
Boaz

>
> --b.
>