From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754964AbaIBSYF (ORCPT ); Tue, 2 Sep 2014 14:24:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57504 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754879AbaIBSYD (ORCPT ); Tue, 2 Sep 2014 14:24:03 -0400 Date: Tue, 2 Sep 2014 11:24:02 -0700 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert Message-ID: <20140902182402.GA12744@kroah.com> References: <1409681795-23262-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1409681795-23262-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > removed unused variables > fixed sparse warning of context imbalance in 'do_locked_client_insert' > different lock contexts for basic block > > Signed-off-by: Sudip Mukherjee > --- > > v1 of the patch of the patch just fixed the sparse warning. > On suggestion of Dan Carpenter v2 is the total rewrite of the function. > Two of the function arguments (interruptHandle,channelId) are also not used. Wanted to remove them as well , > but then thought maybe the original author have planned for some use of those variables. > > drivers/staging/unisys/uislib/uisqueue.c | 37 ++++++++------------------------ > 1 file changed, 9 insertions(+), 28 deletions(-) > > diff --git a/drivers/staging/unisys/uislib/uisqueue.c b/drivers/staging/unisys/uislib/uisqueue.c > index 63dbe7c..acfa46d 100644 > --- a/drivers/staging/unisys/uislib/uisqueue.c > +++ b/drivers/staging/unisys/uislib/uisqueue.c > @@ -78,39 +78,20 @@ do_locked_client_insert(struct uisqueue_info *queueinfo, > u64 interruptHandle, u8 *channelId) > { > unsigned long flags; > - unsigned char queueWasEmpty; > - unsigned int locked = 0; > - unsigned int acquired = 0; > u8 rc = 0; > > spin_lock_irqsave(lock, flags); > - locked = 1; > - > if (!ULTRA_CHANNEL_CLIENT_ACQUIRE_OS(queueinfo->chan, channelId, NULL)) > - goto Away; > - > - acquired = 1; > - > - queueWasEmpty = visor_signalqueue_empty(queueinfo->chan, whichqueue); > - if (!visor_signal_insert(queueinfo->chan, whichqueue, pSignal)) > - goto Away; > - ULTRA_CHANNEL_CLIENT_RELEASE_OS(queueinfo->chan, channelId, NULL); > - acquired = 0; > - > - queueinfo->packets_sent++; > - > - rc = 1; > -Away: > - if (acquired) { > - ULTRA_CHANNEL_CLIENT_RELEASE_OS(queueinfo->chan, channelId, > - NULL); > - acquired = 0; > - } > - if (locked) { > - spin_unlock_irqrestore((spinlock_t *) lock, flags); > - locked = 0; > + goto unlock; > + visor_signalqueue_empty(queueinfo->chan, whichqueue); > + /*visor_signal_insert() only return 0 or 1 */ Odd comment style (hint, you need a ' ' at the beginning...) And why comment this at all? thanks, greg k-h