public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Peter Tyser <ptyser@xes-inc.com>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] x86, lpc, Allow only one load of lpc_ich
Date: Wed, 3 Sep 2014 13:36:06 +0100	[thread overview]
Message-ID: <20140903123606.GG28985@lee--X1> (raw)
In-Reply-To: <54070842.2000700@redhat.com>

> > If only one is useful, why have the second one in the first place?
> 
> That's just it -- it shouldn't have been exposed (again, according to Intel).

I didn't mean at an OS level, I mean what's the point of having two on
the h/w.  I guess only Intel may know.

> > If the devices are present and we can see them, why not have 2?  Some
> > users might find a use for them.
> 
> No one will.

Okay, I guess I have my hackers head on here.  Perhaps this guy
shouldn't probe.  It just seems weird to have a device that we know
about and have register access to, but we're specifying "no playing".

> > In the WARNING you submitted only sysfs was having a hard time.
> > Perhaps the real fix would be to allow the Watchdog and GPIO driver to
> > change their name when registering, so they can each have their own
> > sysfs entries.
> 
> /me scratches head.
> 
> How does that help having multiple devices which shouldn't be exposed?

The fact that they shouldn't be exposed should be neither here nor
there.  I'm thinking that they are exposed, so why suffocate them.
Besides, what happens when there is a use-case for two of these
devices?

How are these guys being registered anyway?  Does PCI detect and
register them automatically?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-09-03 12:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 21:58 [PATCH] x86, lpc, Allow only one load of lpc_ich Prarit Bhargava
2014-09-03  7:43 ` Lee Jones
2014-09-03 10:13   ` Prarit Bhargava
2014-09-03 11:35     ` Lee Jones
2014-09-03 11:55       ` Prarit Bhargava
2014-09-03 12:19         ` Lee Jones
2014-09-03 12:23           ` Prarit Bhargava
2014-09-03 12:36             ` Lee Jones [this message]
2014-09-03 15:57             ` Guenter Roeck
2014-09-03 17:29               ` Peter Tyser
2014-09-03 17:56                 ` Prarit Bhargava
2014-09-03 19:13                   ` Peter Tyser
2014-09-03 20:08                     ` Guenter Roeck
2014-09-03 19:22                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140903123606.GG28985@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=ptyser@xes-inc.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox