public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: early microcode: how to disable at runtime?
Date: Wed, 3 Sep 2014 09:43:02 -0300	[thread overview]
Message-ID: <20140903124302.GA18507@khazad-dum.debian.net> (raw)
In-Reply-To: <20140903064015.GA3941@nazgul.tnic>

On Wed, 03 Sep 2014, Borislav Petkov wrote:
> On Tue, Sep 02, 2014 at 10:16:51AM -0300, Henrique de Moraes Holschuh wrote:
> > Things do go wrong in other ways, not just corrupt microcode data/initramfs
> > images.
> > 
> > This stuff runs too early.  It is easy to break, and annoying to debug.
> 
> How is this stuff easy to break? Please stop with the conjectures and
> give concrete issues, if any.

Half the things you'd usually do when writing kernel code cannot be done
that early, that's how.  It is not that the code is bad or especially
fragile (at least not the core or the AMD driver.  The Intel driver is
convoluted).

You have fixed several such bugs recently, commit ids:
75a1ba5b2c529db60ca49626bcaf0bddf4548438,
84516098b58e05821780dc0b89abcee434b4dca5,
5335ba5cf475369f88db8e6835764efdcad8ab96.

> > Although, on the corrupted microcode topic, I have this very strong
> > feeling that at least the Intel driver would benefit from a careful
> > audit on the microcode container handling if we want to be sure it
> > won't do stupid things when fed specially crafted hostile data.
> 
> If loading the microcode can disrupt the system (and not simply be
> ignored if faulty) then we have to fix that. Disabling the loader is only
> a stop-gap measure in such situation anyway - not a real solution.

Yes.  It is a stop gap solution, I never claimed it to be anything else.

What I did claim is that it is going to be a far more user-friendly stop gap
than the "boot from rescue media" option.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2014-09-03 12:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-09 23:19 BUG: early intel microcode update violating alignment rules Henrique de Moraes Holschuh
2014-08-11 10:22 ` Borislav Petkov
2014-08-11 13:16   ` Henrique de Moraes Holschuh
2014-08-11 14:00     ` Borislav Petkov
2014-08-11 14:50       ` H. Peter Anvin
2014-08-11 18:52       ` Bill Davidsen
2014-08-11 19:15         ` Borislav Petkov
2014-08-14 13:12         ` Henrique de Moraes Holschuh
2014-08-11 14:51 ` H. Peter Anvin
2014-08-11 18:18   ` Henrique de Moraes Holschuh
2014-08-11 18:48     ` H. Peter Anvin
2014-08-31 19:45 ` early microcode: how to disable at runtime? Henrique de Moraes Holschuh
2014-08-31 19:48   ` H. Peter Anvin
2014-08-31 20:11     ` Henrique de Moraes Holschuh
2014-09-01  5:13       ` Borislav Petkov
2014-09-01 10:19         ` Henrique de Moraes Holschuh
2014-09-01 16:35         ` H. Peter Anvin
2014-09-01 17:43           ` Henrique de Moraes Holschuh
2014-09-01 18:48             ` H. Peter Anvin
2014-09-01 19:59               ` Henrique de Moraes Holschuh
2014-09-02  6:33                 ` Borislav Petkov
2014-09-02 13:16                   ` Henrique de Moraes Holschuh
2014-09-03  6:40                     ` Borislav Petkov
2014-09-03 12:43                       ` Henrique de Moraes Holschuh [this message]
2014-09-04 15:42                         ` Borislav Petkov
2014-09-04 17:45                           ` Henrique de Moraes Holschuh
2014-09-05  8:50                             ` Borislav Petkov
2014-09-05 14:23                               ` Henrique de Moraes Holschuh
2014-09-04 18:37                           ` Yu, Fenghua
2014-09-05  8:52                             ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140903124302.GA18507@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox