From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933171AbaICREA (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Sep 2014 13:04:00 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:38133 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932791AbaICRD5 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Sep 2014 13:03:57 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To: Leigh Brown <leigh@solinno.co.uk>,
        "Gregory CLEMENT" <gregory.clement@free-electrons.com>
From: Mike Turquette <mturquette@linaro.org>
In-Reply-To: <902cee907da9c532822dcf5db722b47c@doppler.thel33t.co.uk>
Cc: linux-kernel@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
        "Andrew Lunn" <andrew@lunn.ch>,
        "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
        "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
        "Ezequiel Garcia" <ezequiel.garcia@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org,
        "Lior Amsalem" <alior@marvell.com>,
        "Tawfik Bayouk" <tawfik@marvell.com>,
        "Nadav Haklai" <nadavh@marvell.com>,
        "Raphael Rigo" <ml-arm@syscall.eu>,
        "Arnaud Ebalard" <arno@natisbad.org>,
        "Simon Boulay" <simon.boulay@vitec.com>
References: <1409645719-20003-1-git-send-email-gregory.clement@free-electrons.com>
 <902cee907da9c532822dcf5db722b47c@doppler.thel33t.co.uk>
Message-ID: <20140903170339.11368.17168@quantum>
User-Agent: alot/0.3.5
Subject: Re: [PATCH V2 0/4] clk: mvebu: Improve clock drift
Date: Wed, 03 Sep 2014 10:03:39 -0700
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Leigh Brown (2014-09-03 07:40:56)
> On 2014-09-02 09:15, Gregory CLEMENT wrote:
> > Few users reported a timer drift on the Armada 370 based board such as
> > the mirabox or the Netgear ReadyNAS 102. This is the second series
> > with few improvements after the review of the 1st version.
> > 
> > The reason is that when the SSCG (Spread Spectrum Clock Generator) is
> > enabled, it shifts the frequency of the clock. The percentage is no
> > more than 1% but when the clock is used for a timer it leads to a
> > clock drift.
> > 
> > This series allows to correct the affected clock when the SSCG is
> > enabled. This drift can happen on all the mvebu SoC on the cpu clock
> > block (ie cpu, ddr and l2 cache). Currently the only notable effect is
> > for the Armada 370 because this SoC use the l2cache clock as source
> > for the timer. That's why even if the series allow any of the mvebu
> > SoC to benefit to this correction, Armada 370 is the only user of it.
> > 
> > The first 2 patches should go through the clk subsystem, whereas the
> > third one should go to the arm-soc through the mvebu tree.
> > 
> > The last one is just to fix a typo I found while I was reading the clk
> > code.
> 
> This is working superbly for me on my Mirabox, and ntpd is now 
> completely stable.
> 
> Tested-by: Leigh Brown <leigh@solinno.co.uk>
> 

Clock patches look good to me.

Regards,
Mike