From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Catalin Iacob <iacobcatalin@gmail.com>,
Dave Jones <davej@redhat.com>, Ingo Molnar <mingo@kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 3/9] irq_work: Force raised irq work to run on irq work interrupt
Date: Thu, 4 Sep 2014 15:33:40 +0200 [thread overview]
Message-ID: <20140904133337.GA1771@lerouge> (raw)
In-Reply-To: <20140904061137.GB3190@worktop.ger.corp.intel.com>
On Thu, Sep 04, 2014 at 08:11:37AM +0200, Peter Zijlstra wrote:
> On Thu, Aug 21, 2014 at 04:52:51PM +0200, Frederic Weisbecker wrote:
> > diff --git a/kernel/irq_work.c b/kernel/irq_work.c
> > index e6bcbe7..17bd203 100644
> > --- a/kernel/irq_work.c
> > +++ b/kernel/irq_work.c
> > @@ -22,6 +22,7 @@
> >
> > static DEFINE_PER_CPU(struct llist_head, raised_list);
> > static DEFINE_PER_CPU(struct llist_head, lazy_list);
> > +static bool has_own_interrupt;
> >
> > /*
> > * Claim the entry so that no one else will poke at it.
>
> > +void irq_work_tick(void)
> > +{
> > + if (!has_own_interrupt)
> > + irq_work_run_list(&__get_cpu_var(raised_list));
> > + irq_work_run_list(&__get_cpu_var(lazy_list));
> > +}
> > +
> > /*
> > * Synchronize against the irq_work @entry, ensures the entry is not
> > * currently in use.
>
> Why not something like the below; then it becomes a compile time matter.
Problem is that some archs only have that information at runtime.
See x86 for example which tests cpu_has_apic.
next prev parent reply other threads:[~2014-09-04 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 14:52 [RFC PATCH 0/9] nohz: Nohz full kick fixes Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 1/9] nohz: Restore NMI safe local irq work for local nohz kick Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 2/9] nohz: Move nohz full init call to tick init Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 3/9] irq_work: Force raised irq work to run on irq work interrupt Frederic Weisbecker
2014-09-04 6:11 ` Peter Zijlstra
2014-09-04 13:33 ` Frederic Weisbecker [this message]
2014-09-04 15:40 ` Peter Zijlstra
2014-09-05 13:54 ` Frederic Weisbecker
2014-09-06 13:35 ` Frederic Weisbecker
2014-09-06 15:45 ` Peter Zijlstra
2014-09-06 17:12 ` Frederic Weisbecker
2014-09-08 6:11 ` Peter Zijlstra
2014-08-21 14:52 ` [RFC PATCH 4/9] x86: Build irq work only if local apic support Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 5/9] x86: Tell irq work about self IPI support Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 6/9] arm: " Frederic Weisbecker
2014-08-21 15:21 ` Russell King - ARM Linux
2014-08-21 17:35 ` Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 7/9] arm64: " Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 8/9] nohz: Consolidate nohz full init code Frederic Weisbecker
2014-08-21 14:52 ` [RFC PATCH 9/9] nohz: nohz full depends on irq work self IPI support Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904133337.GA1771@lerouge \
--to=fweisbec@gmail.com \
--cc=davej@redhat.com \
--cc=iacobcatalin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox