From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754239AbaIDQlh (ORCPT ); Thu, 4 Sep 2014 12:41:37 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:59544 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbaIDQle (ORCPT ); Thu, 4 Sep 2014 12:41:34 -0400 Date: Thu, 4 Sep 2014 22:11:16 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Sudip Mukherjee , Benjamin Romer , David Kershner , Greg Kroah-Hartman , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert Message-ID: <20140904164116.GA1084@sudip-PC> References: <1409736561-23883-1-git-send-email-sudip@vectorindia.org> <20140903095950.GF6600@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140903095950.GF6600@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 03, 2014 at 12:59:50PM +0300, Dan Carpenter wrote: > On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote: > > 1) removed unused variables > > 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' > > different lock contexts for basic block > > 3) removed the call to visor_signalqueue_empty() , this function is > > checking whether a signal queue is empty, but the return value > > of the function is not beeing used, so it is safe to remove. > > > > Signed-off-by: Sudip Mukherjee > > Looks good. Thanks! > > Reviewed-by: Dan Carpenter > > regards, > dan carpenter do i need to resend the patch after adding Reviewed-by to it ? thanks sudip > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/