From: Matt Fleming <matt@console-pimps.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Yinghai Lu" <yinghai@kernel.org>,
"Matt Fleming" <matt.fleming@intel.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Mantas Mikulėnas" <grawity@gmail.com>,
"Anders Darander" <anders@chargestorm.se>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [PATCH -v4] x86: only load initrd above 4g on second try
Date: Thu, 4 Sep 2014 22:29:25 +0100 [thread overview]
Message-ID: <20140904212925.GL3001@console-pimps.org> (raw)
In-Reply-To: <5408D299.5000300@zytor.com>
On Thu, 04 Sep, at 01:59:05PM, H. Peter Anvin wrote:
>
> I am fine with this patch, but at the same time I do want to note that
> there is an alternative to double-buffer the patch and/or (if that
> applies to the buggy BIOS) round up the size of the target buffer.
I'm not sure that rounding up the size of the target buffer will
workaround this issue correctly.
As far as I know, the only thing that Mantas tried was rounding up the
size of the source file, by padding it.
Laszlo, is there anything we can do in the kernel to avoid the EDK2 bug
you fixed here,
https://github.com/tianocore/edk2/commit/4e39b75e
such as lying about the number of bytes we're trying to read or
allocating a bigger target buffer than we actually need?
Assuming of course, that the bug that Laszlo fixed and the bug that
Mantas is hitting are one and the same.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-04 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 4:50 [PATCH -v4] x86: only load initrd above 4g on second try Yinghai Lu
2014-09-04 10:01 ` Matt Fleming
2014-09-04 20:59 ` H. Peter Anvin
2014-09-04 21:29 ` Matt Fleming [this message]
2014-09-05 1:19 ` Yinghai Lu
2014-09-05 5:47 ` Anders Darander
2014-09-05 6:38 ` Laszlo Ersek
2014-09-05 17:03 ` Yinghai Lu
2014-09-05 19:20 ` Laszlo Ersek
2014-09-05 22:16 ` Matt Fleming
2014-09-06 19:05 ` Anders Darander
2014-09-06 20:09 ` Mantas Mikulėnas
2014-09-06 20:10 ` Mantas Mikulėnas
2014-09-08 15:58 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140904212925.GL3001@console-pimps.org \
--to=matt@console-pimps.org \
--cc=anders@chargestorm.se \
--cc=grawity@gmail.com \
--cc=hpa@zytor.com \
--cc=lersek@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).