Re: [PATCH] regulator: hi6421: Fix misleading comment

Guodong Xu
2014-09-05T09:17:06Z

Thanks. Could you also change the comments in macro defines, like here:

diff --git a/drivers/regulator/hi6421-regulator.c
b/drivers/regulator/hi6421-regulator.c
index e389920..156d0d1 100644
--- a/drivers/regulator/hi6421-regulator.c
+++ b/drivers/regulator/hi6421-regulator.c
@@ -37,7 +37,7 @@ struct hi6421_regulator_pdata {
* struct hi6421_regulator_info - hi6421 regulator information
* @desc: regulator description
* @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep
- * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only
+ * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only
*/
struct hi6421_regulator_info {
struct regulator_desc desc;
@@ -164,7 +164,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO(_id, v_table, vreg, vmask, ereg, emask, \
odelay, ecomask, ecoamp) \
@@ -200,7 +200,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO_LINEAR(_id, _min_uV, n_volt, vstep, vreg, vmask, \
ereg, emask, odelay, ecomask, ecoamp) \
@@ -237,7 +237,7 @@ static const struct regulator_ops hi6421_buck345_ops;
* emask - enable mask
* odelay - off/on delay time in uS
* ecomask - eco mode mask
- * ecoamp - eco mode load uppler limit in mA
+ * ecoamp - eco mode load uppler limit in uA
*/
#define HI6421_LDO_LINEAR_RANGE(_id, n_volt, volt_ranges, vreg, vmask, \
ereg, emask, odelay, ecomask, ecoamp) \

Thanks.

Best regards,
Guodong Xu

On 09/05/2014 09:14 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/hi6421-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/hi6421-regulator.c b/drivers/regulator/hi6421-regulator.c
> index e389920..a8c362c 100644
> --- a/drivers/regulator/hi6421-regulator.c
> +++ b/drivers/regulator/hi6421-regulator.c
> @@ -37,7 +37,7 @@ struct hi6421_regulator_pdata {
> * struct hi6421_regulator_info - hi6421 regulator information
> * @desc: regulator description
> * @mode_mask: ECO mode bitmask of LDOs; for BUCKs, this masks sleep
> - * @eco_microamp: eco mode load upper limit (in mA), valid for LDOs only
> + * @eco_microamp: eco mode load upper limit (in uA), valid for LDOs only
> */
> struct hi6421_regulator_info {
> struct regulator_desc desc;
>