From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbaIEWt0 (ORCPT ); Fri, 5 Sep 2014 18:49:26 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:60810 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbaIEWtV (ORCPT ); Fri, 5 Sep 2014 18:49:21 -0400 Date: Fri, 5 Sep 2014 15:49:17 -0700 From: Dmitry Torokhov To: Tejun Heo Cc: "Luis R. Rodriguez" , Greg Kroah-Hartman , Wu Zhangjin , Takashi Iwai , Arjan van de Ven , "linux-kernel@vger.kernel.org" , Oleg Nesterov , hare@suse.com, Andrew Morton , Tetsuo Handa , Joseph Salisbury , Benjamin Poirier , Santosh Rastapur , Kay Sievers , One Thousand Gnomes , Tim Gardner , Pierre Fersing , Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , Casey Leedom , Hariprasad S , MPT-FusionLinux.pdl@avagotech.com, Linux SCSI List , "netdev@vger.kernel.org" Subject: Re: [RFC v2 3/6] kthread: warn on kill signal if not OOM Message-ID: <20140905224917.GB35667@core.coreip.homeip.net> References: <1409899047-13045-1-git-send-email-mcgrof@do-not-panic.com> <20140905141241.GC10455@mtj.dyndns.org> <20140905164405.GA28964@core.coreip.homeip.net> <20140905174925.GA12991@mtj.dyndns.org> <20140905181003.GA29003@core.coreip.homeip.net> <20140905222956.GA15723@mtj.dyndns.org> <20140905223139.GB15723@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140905223139.GB15723@mtj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 06, 2014 at 07:31:39AM +0900, Tejun Heo wrote: > On Sat, Sep 06, 2014 at 07:29:56AM +0900, Tejun Heo wrote: > > It is for storage devices which always have guaranteed synchronous > > probing on module load and well-defined probing order. Agree about probing order (IIRC that is why we had to revert the wholesale asynchronous probing a few years back) but totally disagree about synchronous module loading. Anyway, I just posted a patch that I think preserves module loading behavior and solves my issue with built-in modules. It does not help Luis' issue though (but then I think the main problem is with systemd being stupid there). > > Sure, modern > > setups are a lot more dynamic but I'm quite certain that there are > > setups in the wild which depend on storage driver loading being > > synchronous. We can't simply declare one day that such behavior is > > broken and break, most likely, their boots. > > To add a bit, if the argument here is that dependency on such behavior > shouldn't exist and module loading and device probing should always be > asynchronous, the right approach is implementing "synchronous_probing" > flag not the other way around. I actually wouldn't hate to see that > change happening but whoever submits and routes such a change should > be ready for a major shitstorm, I'm afraid. I think we already had this storm and that is why here we have opt-in behavior for the drivers. Thanks. -- Dmitry