From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Daniel Bomar <dbdaniel42@gmail.com>,
"Theodore Ts'o" <tytso@mit.edu>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Fixed styling issues
Date: Sun, 7 Sep 2014 08:46:25 -0700 [thread overview]
Message-ID: <20140907154625.GA18274@infradead.org> (raw)
In-Reply-To: <CAFLxGvwVNTXw1uvzJaTyo6EQNgGWuAnGTi7s2+r3P+zF71zD3A@mail.gmail.com>
On Sun, Sep 07, 2014 at 03:16:22PM +0200, Richard Weinberger wrote:
> On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@gmail.com> wrote:
> > Fixed styling issues as reported by scripts/checkpatch.pl
> >
> > Signed-off-by: Daniel Bomar <dbdaniel42@gmail.com>
>
> Please don't run checkpatch.pl on in-kernel files.
I don't think it's up to us to tell people what files they should run
patches on on.. That doesn't mean that pure style cleanup patches in an
area you don't understand are a good idea, so don't send them. This is
different when you actually do a major overhaul of an area, in which
case I'd actually like to do a first pass of style cleanup and
refactoring before submitting the real work.
prev parent reply other threads:[~2014-09-07 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 12:45 [PATCH] ext4: Fixed styling issues Daniel Bomar
2014-09-07 13:16 ` Richard Weinberger
2014-09-07 15:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140907154625.GA18274@infradead.org \
--to=hch@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=dbdaniel42@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox