From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754399AbaIHQ1f (ORCPT ); Mon, 8 Sep 2014 12:27:35 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:58949 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753550AbaIHQ1e (ORCPT ); Mon, 8 Sep 2014 12:27:34 -0400 Date: Mon, 8 Sep 2014 21:57:14 +0530 From: Sudip Mukherjee To: "Romer, Benjamin M" Cc: "Kershner, David A" , *S-Par-Maintainer , Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance Message-ID: <20140908162714.GA5497@fool> References: <1409908966-23148-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote: > On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote: > > fixed sparse warning : context imbalance in 'pause_device' > > unexpected unlock > > this patch will generate warning from checkpatch for > > lines over 80 character , but since those are user-visible strings > > so it was not modified. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > hi , can you please review the patch and see if the approach is correct. > > The functiion is still doing the same what it was doing , only the logic > > is changed. if the approach is ok, then i can send a patch to fix the > > other two similar warning in the file. > > Hi Sudip, > > I was able to successfully build and test your patch. The changes look > good to me too, so I think we should take this patch. :) > > Thanks! > -- Ben > Hi Ben, thanks. the same file is having two more similar warnings. if you want i can resend a patch fixing all the three warnings , or i can send two separate patches. I personally will prefer two separate patches , as that will be easier for you to test and review. thanks sudip > Signed-off-by: Benjamin Romer > Tested-by: Benjamin Romer