From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Romer, Benjamin M" <Benjamin.Romer@unisys.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Kershner, David A" <David.Kershner@unisys.com>,
*S-Par-Maintainer <SParMaintainer@unisys.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance
Date: Mon, 8 Sep 2014 10:24:54 -0700 [thread overview]
Message-ID: <20140908172454.GA11205@kroah.com> (raw)
In-Reply-To: <C97001BC43954D438ACB059713BA5CDFC97127E0E5@USEA-EXCH7.na.uis.unisys.com>
On Mon, Sep 08, 2014 at 12:10:55PM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> > Traditionally, you would respond with a:
> > Acked-by: Developer Name <email@address>
> > so I can add it to the patch.
> >
> > Care to do that here?
> >
> > thanks,
> >
> > greg k-h
>
> Of course. :)
>
> Acked-by: Benjamin Romer <benjamin.romer@unisys.com>
>
> Should I do this instead of Tested-by and Signed-off-by, in the future?
If you test it, do a tested-by.
If you sign off on it (i.e. it flows through you to me), then a
signed-off is correct.
Hope this helps,
greg k-h
next prev parent reply other threads:[~2014-09-08 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 9:22 [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance Sudip Mukherjee
2014-09-08 15:57 ` Romer, Benjamin M
2014-09-08 16:27 ` Sudip Mukherjee
2014-09-08 16:30 ` Romer, Benjamin M
2014-09-08 16:38 ` Sudip Mukherjee
2014-09-08 16:48 ` Romer, Benjamin M
2014-09-08 17:02 ` Sudip Mukherjee
2014-09-08 17:06 ` Greg Kroah-Hartman
2014-09-08 17:10 ` Romer, Benjamin M
2014-09-08 17:24 ` Greg Kroah-Hartman [this message]
2014-09-08 17:33 ` Romer, Benjamin M
-- strict thread matches above, loose matches on Subject: below --
2014-09-09 10:41 Sudip Mukherjee
2014-09-10 13:29 ` Romer, Benjamin M
2014-09-10 13:55 ` Sudip Mukherjee
2014-09-12 12:27 Sudip Mukherjee
2014-09-12 18:20 ` Ben Romer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908172454.GA11205@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Benjamin.Romer@unisys.com \
--cc=David.Kershner@unisys.com \
--cc=SParMaintainer@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox