From: Nishanth Menon <nm@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: <bcousson@baylibre.com>, <tony@atomide.com>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [resend PATCH 1/3] pinctrl: dra7: dt-bindings: add pin off modes for dra7 SoC
Date: Mon, 8 Sep 2014 14:32:35 -0500 [thread overview]
Message-ID: <20140908193235.GA12150@kahuna> (raw)
In-Reply-To: <1410203998-8700-2-git-send-email-mugunthanvnm@ti.com>
On 00:49-20140909, Mugunthan V N wrote:
> Add pin off modes for dra7 SoC so that during module disable or suspend
> state it can help saving power
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> include/dt-bindings/pinctrl/dra.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/dra.h b/include/dt-bindings/pinctrl/dra.h
> index 002a285..a0ff2d0 100644
> --- a/include/dt-bindings/pinctrl/dra.h
> +++ b/include/dt-bindings/pinctrl/dra.h
> @@ -46,5 +46,13 @@
> #define PIN_INPUT_PULLUP (PULL_ENA | INPUT_EN | PULL_UP)
> #define PIN_INPUT_PULLDOWN (PULL_ENA | INPUT_EN)
>
> +/* Off mode states */
> +#define PIN_OFF_NONE 0
> +#define PIN_OFF_OUTPUT_HIGH (OFF_EN | OFFOUT_EN | OFFOUT_VAL)
> +#define PIN_OFF_OUTPUT_LOW (OFF_EN | OFFOUT_EN)
> +#define PIN_OFF_INPUT_PULLUP (OFF_EN | OFF_PULL_EN | OFF_PULL_UP)
> +#define PIN_OFF_INPUT_PULLDOWN (OFF_EN | OFF_PULL_EN)
> +#define PIN_OFF_WAKEUPENABLE WAKEUP_EN
> +
> #endif
NAK for OFF_NONE, OFF_xyz etc.
A) There is no OFF mode on DRA7. in sleep state use mode 15 (gated).
B) when using this for wakeup - use pinctrl wakeup handling to do the
wakeup.
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-08 19:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 19:19 [resend PATCH 0/3] Add DRA7xx CPSW Ethernet support in Device Tree Mugunthan V N
2014-09-08 19:19 ` [resend PATCH 1/3] pinctrl: dra7: dt-bindings: add pin off modes for dra7 SoC Mugunthan V N
2014-09-08 19:32 ` Nishanth Menon [this message]
2014-09-09 9:17 ` Mugunthan V N
2014-09-08 19:19 ` [resend PATCH 2/3] arm/dts: dra7xx: Add CPSW and MDIO module nodes for dra7xx Mugunthan V N
2014-09-08 19:19 ` [resend PATCH 3/3] arm/dts: dra7xx: Enable CPSW and MDIO for dra7xx EVM Mugunthan V N
2014-09-08 19:33 ` Nishanth Menon
2014-09-08 19:34 ` [resend PATCH 0/3] Add DRA7xx CPSW Ethernet support in Device Tree Nishanth Menon
2014-09-09 11:29 ` Mugunthan V N
2014-09-09 12:15 ` Nishanth Menon
2014-09-09 12:56 ` Mugunthan V N
2014-09-09 13:04 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908193235.GA12150@kahuna \
--to=nm@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox