From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbaIHTdt (ORCPT ); Mon, 8 Sep 2014 15:33:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34321 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbaIHTdr (ORCPT ); Mon, 8 Sep 2014 15:33:47 -0400 Date: Mon, 8 Sep 2014 12:33:47 -0700 From: Greg KH To: Aaro Koskinen Cc: Nitin Kuppelur , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions Message-ID: <20140908193347.GA13636@kroah.com> References: <1410196395-4595-1-git-send-email-nitinkuppelur@gmail.com> <20140908185923.GA10550@drone.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140908185923.GA10550@drone.musicnaut.iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote: > On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote: > > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by removing return statement from void functions. > > Please format line length to <= 76 characters in the commit log. > > Maybe you could fix __cvmx_usb_perform_complete() as well? What is wrong with it? That should be in a separate patch... thanks, greg k-h