From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755472AbaIIABw (ORCPT ); Mon, 8 Sep 2014 20:01:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36612 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755221AbaIIABf (ORCPT ); Mon, 8 Sep 2014 20:01:35 -0400 Date: Mon, 8 Sep 2014 17:01:34 -0700 From: Greg Kroah-Hartman To: Peter Hurley Cc: Jiri Slaby , One Thousand Gnomes , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/26] tty/serial flow control fixes Message-ID: <20140909000134.GA14714@kroah.com> References: <1409693975-1028-1-git-send-email-peter@hurleysoftware.com> <20140908232445.GA28204@kroah.com> <540E3CDF.8020607@hurleysoftware.com> <20140908234324.GA14132@kroah.com> <540E3FC6.2010503@hurleysoftware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <540E3FC6.2010503@hurleysoftware.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 08, 2014 at 07:46:14PM -0400, Peter Hurley wrote: > On 09/08/2014 07:43 PM, Greg Kroah-Hartman wrote: > > On Mon, Sep 08, 2014 at 07:33:51PM -0400, Peter Hurley wrote: > >> On 09/08/2014 07:24 PM, Greg Kroah-Hartman wrote: > >>> On Tue, Sep 02, 2014 at 05:39:09PM -0400, Peter Hurley wrote: > >>>> Hi Greg, > >>>> > >>>> This patch series reworks the internals of tty and serial flow control to > >>>> fix multiple races in both START/STOP flow control and RTS/CTS flow control. > >>>> > >>>> The main changes in this series are: > >>>> Patch 1 > >>>> Backs out the UPF_HARD_FLOW kludge for 8250. This revert should be > >>>> for mainline and -next > >>>> > >>>> Patches 3-7 > >>>> Fixes to x_char handling (ie., sending START/STOP) both in the serial > >>>> core and to several UART drivers > >>>> > >>>> Patches 10-15 > >>>> Rename and move ASYNC_CTS_FLOW and ASYNC_CHECK_CD statuses into > >>>> a private field for the serial core, and add helper functions to test > >>>> those statuses for UART drivers. > >>>> > >>>> This is a necessary step toward making tty port->flags SMP-safe, without > >>>> introducing a new lock. > >>> > >>> I stopped applying at patch 13, due to the objections to that patch. > >>> Please redo the rest of the series and resend. > >> > >> I'm going to wait for the fallout from patch 21 to shake out first. > > > > Why, the earlier patches in this series should be ok to go, right? They > > don't depend on 21 to be "correct". > > Oh, you want me to redo just 14 through 20, and resend that? Sure, might as well get those out of the way :)