Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

Jason Cooper
2014-08-29T12:48:46Z

On Fri, Aug 29, 2014 at 01:42:16PM +0100, Mark Rutland wrote:
> On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote:
> > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote:
...
Someone wrote:
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1307.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1337.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1338.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1339.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1340.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1388.pdf
> > > > > > > http://datasheets.maximintegrated.com/en/ds/DS3231.pdf
...
> > > I would suggest we have two properties that describe the resistor's
> > > rating and whether or not there is a diode:
> > >
> > > trickle-resistor-ohms = <250>
> > > diode-connected;
> >
> > I much prefer this solution over my own suggestion. With one small
> > change, s/diode-connected/trickle-diode-enable/ Does that sound ok?
>
> I'm not too keen on 'enable'; I was under the impression that this
> described whether or not there was an external diode. Perhaps I've
> misunderstood?

iiuc from the link ds1339 ds, the register configuration is enabling
internal diodes and resistors for the trickle charge configuration. I
may have read it incorrectly, though.

In either case, my main point was to prepend 'trickle-' to the property
to more accurately describe what it is toggling.

thx,

Jason.