From: Johan Hovold <johan@kernel.org>
To: Wang YanQing <udknight@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Benjamin Henrion <zoobab@gmail.com>,
gregkh@linuxfoundation.org, linus.walleij@linaro.org,
jhovold@gmail.com, andi@lisas.de, dforsi@gmail.com,
gnomes@lxorguk.ukuu.org.uk, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303
Date: Tue, 9 Sep 2014 16:02:04 +0200 [thread overview]
Message-ID: <20140909140204.GB7939@localhost> (raw)
In-Reply-To: <20140909104356.GA7939@localhost>
On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote:
> On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote:
> > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote:
> > > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote:
> > > > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote:
> > > > > On Thu, Sep 4, 2014 at 6:14 PM, Benjamin Henrion <zoobab@gmail.com> wrote:
> > > > > > I have subscribed to the lkml.
> > > > > >
> > > > > > Can you make me a favour, send me your email as you posted on the LKML
> > > > > > in mbox format attached to an email?
> > > > > >
> > > > > > I am trying to reply to it, but I cannot find an mbox archive, outside
> > > > > > of gmane which rewrites all the email addresses.
> > > > > >
> > > > > > Otherwise, I made a page here:
> > > > > >
> > > > > > http://www.zoobab.com/pl2303hxd-gpio
> > > > > >
> > > > > > I will also try with other adapters to see if the 2 GPIOs show up.
> > > > > >
> > > > > > Any idea how to test the GPIO sysfs speed?
> > > > >
> > > > > Also tested with an HXA laying around, I could export the 2 GPIOS in
> > > > > /sys/class/gpio, but I could not change the status of the pins via
> > > > > echo.
> > > > >
> > > > > Any idea why?
> > > >
> > > > It is strange, I have tested again with my two HXA adapters, they work well.
> > > > How do you test? check cat value or check voltage change? I check cat value,
> > > > and they work good.
> > >
> > > So you haven't verified that the voltage actually changes?
> > >
> > > Johan
> >
> > I have verified the voltage actually changes in previous patch version,
> > but I haven't verified that with v8.
>
> Ok, good. I'll get back to you with some comments on v8 shortly.
Wait a minute. You restructured the driver, added support for two new
gpios as well as another device type, so you need to verify the voltage
on the pins (on both device types) as well.
Thanks,
Johan
next prev parent reply other threads:[~2014-09-09 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140831153201.GA25632@udknight>
[not found] ` <CANjd3neT+NrsptLw3s7Bm76xv6LQMqm-BieN-0xLFuTx4apXxw@mail.gmail.com>
[not found] ` <CANjd3ndGiTujCORwZOXfWfHL2_YocK5ZUpxQJPLq+qTmkV0xnA@mail.gmail.com>
2014-09-05 1:30 ` [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303 Wang YanQing
2014-09-09 10:08 ` Johan Hovold
2014-09-09 10:21 ` Wang YanQing
2014-09-09 10:43 ` Johan Hovold
2014-09-09 14:02 ` Johan Hovold [this message]
2014-09-10 1:56 ` Wang YanQing
2014-09-10 1:58 ` Wang YanQing
2014-08-31 15:24 Wang YanQing
2014-09-04 16:56 ` Linus Walleij
2014-09-04 17:35 ` Wang YanQing
2014-09-04 21:57 ` Benjamin Henrion
2014-09-05 7:58 ` Linus Walleij
2014-09-10 7:59 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909140204.GB7939@localhost \
--to=johan@kernel.org \
--cc=andi@lisas.de \
--cc=dforsi@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jhovold@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=udknight@gmail.com \
--cc=zoobab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox