From: Greg KH <greg@kroah.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "James E . J . Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/3] parisc/uapi: Add definition of TIOC[SG]RS485
Date: Tue, 9 Sep 2014 11:43:18 -0700 [thread overview]
Message-ID: <20140909184318.GA6231@kroah.com> (raw)
In-Reply-To: <1410285991-24833-1-git-send-email-ricardo.ribalda@gmail.com>
On Tue, Sep 09, 2014 at 08:06:31PM +0200, Ricardo Ribalda Delgado wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add
> support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and
> TIOCGRS485 was missing on the ioctls.h file
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> arch/parisc/include/uapi/asm/ioctls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/parisc/include/uapi/asm/ioctls.h b/arch/parisc/include/uapi/asm/ioctls.h
> index 66719c3..3af2d02 100644
> --- a/arch/parisc/include/uapi/asm/ioctls.h
> +++ b/arch/parisc/include/uapi/asm/ioctls.h
> @@ -50,6 +50,8 @@
> #define TCSETS2 _IOW('T',0x2B, struct termios2)
> #define TCSETSW2 _IOW('T',0x2C, struct termios2)
> #define TCSETSF2 _IOW('T',0x2D, struct termios2)
> +#define TIOCGRS485 0x542E
> +#define TIOCSRS485 0x542F
As David pointed out with the sparc patch, please use the proper ioctl
macros for these numbers.
Please redo all of these patches and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2014-09-09 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 18:06 [PATCH 1/3] parisc/uapi: Add definition of TIOC[SG]RS485 Ricardo Ribalda Delgado
2014-09-09 18:43 ` Greg KH [this message]
2014-09-09 18:46 ` Ricardo Ribalda Delgado
2014-09-09 18:58 ` Greg KH
2014-09-09 19:02 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909184318.GA6231@kroah.com \
--to=greg@kroah.com \
--cc=deller@gmx.de \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox