From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nitin Kuppelur <nitinkuppelur@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: octeon-hcd: removed dummy label
Date: Tue, 9 Sep 2014 22:02:00 +0300 [thread overview]
Message-ID: <20140909190200.GT6600@mwanda> (raw)
In-Reply-To: <1410276139-7212-1-git-send-email-nitinkuppelur@gmail.com>
On Tue, Sep 09, 2014 at 05:22:19PM +0200, Nitin Kuppelur wrote:
> This is a patch to the octeon-hcd.c file that
> removes dummy label i.e. label followed by return of
> void function
>
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 8a80982..5fffef2 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
> /* Increment to the next location in our packet array */
> transaction->iso_packets++;
> transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
> - goto done;
> + return;
> }
> - }
>
Wat? Does this still compile without the curly brace?
regards,
dan carpenter
next prev parent reply other threads:[~2014-09-09 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 15:22 [PATCH] Staging: octeon-hcd: removed dummy label Nitin Kuppelur
2014-09-09 19:02 ` Dan Carpenter [this message]
2014-09-10 1:29 ` Nitin Kuppelur
2014-09-10 1:36 ` [PATCH V2] " Nitin Kuppelur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909190200.GT6600@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nitinkuppelur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox