Re: [PATCH 4/4] export the kernel image size KERNEL_IMAGE_SIZE

Kees Cook
2014-09-05T17:00:11Z

On Fri, Sep 5, 2014 at 7:08 AM, Baoquan He <bhe@redhat.com> wrote:
> Now kaslr makes kernel image size changable, not the fixed size 512M.
> So KERNEL_IMAGE_SIZE need be exported to VMCOREINFO, otherwise makedumfile
> will crash.

Seems like a good idea, yes.

>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> kernel/kexec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 2bee072..bd680d3 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -2003,6 +2003,9 @@ static int __init crash_save_vmcoreinfo_init(void)
> #endif
> VMCOREINFO_NUMBER(PG_head_mask);
> VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
> +#ifdef CONFIG_X86
> + VMCOREINFO_NUMBER(KERNEL_IMAGE_SIZE);
> +#endif
> #ifdef CONFIG_HUGETLBFS
> VMCOREINFO_SYMBOL(free_huge_page);
> #endif

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

--
Kees Cook
Chrome OS Security