Re: [PATCH 1/4] kaslr: check user's config too when handle relocations

Kees Cook
2014-09-11T16:18:56Z

On Thu, Sep 11, 2014 at 2:31 AM, Baoquan He <bhe@redhat.com> wrote:
> On 09/10/14 at 07:41am, Kees Cook wrote:
>> On Wed, Sep 10, 2014 at 7:30 AM, Vivek Goyal <vgoyal@redhat.com> wrote:
>> > So I would suggest that test and repost the other patch with proper changelog
>> > and that might be sufficient for now. Only other thing we will need is
>> > Kees's patch for avoiding setup data regions in kaslr.
>>
>> If someone can confirm that my patch works, I can request x86 pull it.
>>
>> Currently living here:
>> https://git.kernel.org/cgit/linux/kernel/git/kees/linux.git/log/?h=kaslr
>
> Hi Kees,
>
> I tested your patch, it works. The way is like below:
>
> I changed kexec-tools to make all add_buffer doing from down to top.
> Then all stuff including kernel, initrd, setupda, cmdline, realmode_data
> all are put inside 0~1G. And set E820_MAX to 10, since on my pc there are 17
> memoery regions, then 7 memory regions are added into setup_data as a
> blob. Then copy arch/x86/boot/printf.c to arch/x86/boot/compressed/ and
> make it work. From printing message, the setup data is checking each
> time when a memory slot is added.

Great! Thanks very much! I'll send the patch to Peter now.

-Kees

--
Kees Cook
Chrome OS Security