From: Mark Brown <broonie@kernel.org>
To: Robin Gong <b38343@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, marex@denx.de,
shawn.guo@linaro.org, Frank.Li@freescale.com
Subject: Re: [PATCH v5] spi: spi-imx: add DMA support
Date: Wed, 10 Sep 2014 12:45:30 +0100 [thread overview]
Message-ID: <20140910114530.GD7960@sirena.org.uk> (raw)
In-Reply-To: <20140910112258.GA30794@Robin-OptiPlex-780>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On Wed, Sep 10, 2014 at 07:22:59PM +0800, Robin Gong wrote:
> On Wed, Sep 10, 2014 at 11:21:05AM +0100, Mark Brown wrote:
> > This isn't going to work, anything that looks at the usedma flag will
> > see the result of the last thing that was checked which may or may not
> > be the transfer that it's handling. The driver should check to see if
> > the core mapped the transfer for DMA.
> Yes, you're right. I should use "transfer->tx_sg->sgl == NULL" or
> "transfer->rx_sg->sgl == NULL" instead of usedma flag in driver, right?
Right.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-10 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 1:30 [PATCH v5] spi: spi-imx: add DMA support Robin Gong
2014-09-10 4:16 ` Varka Bhadram
2014-09-10 5:46 ` Robin Gong
2014-09-10 8:17 ` Arnd Bergmann
2014-09-10 8:28 ` Robin Gong
2014-09-10 10:21 ` Mark Brown
2014-09-10 11:22 ` Robin Gong
2014-09-10 11:45 ` Mark Brown [this message]
2014-09-10 15:18 ` Robin Gong
2014-09-10 15:52 ` Mark Brown
2014-09-11 1:37 ` Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910114530.GD7960@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Frank.Li@freescale.com \
--cc=b38343@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marex@denx.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox