From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, mingo@kernel.org,
eranian@google.com, tglx@linutronix.de
Subject: Re: [PATCH 2/2] perf, x86: Use INTEL_FLAGS_UEVENT_CONSTRAINT for PRECDIST
Date: Wed, 10 Sep 2014 16:22:32 +0200 [thread overview]
Message-ID: <20140910142232.GC4783@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <20140910140258.GI5387@tassilo.jf.intel.com>
On Wed, Sep 10, 2014 at 07:02:58AM -0700, Andi Kleen wrote:
> On Wed, Sep 10, 2014 at 09:59:26AM +0200, Peter Zijlstra wrote:
> > On Tue, Sep 09, 2014 at 05:49:08PM -0700, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > The earlier commit 86a04461a made near all PEBS on
> > > Sandy/IvyBridge/Haswell to reject non zero flags.
> >
> > What's magic about nehalem and westmere?
>
> I wasn't able to confirm their behavior explicitly, so I felt
> it best to leave them alone.
>
> But in principle adding the _FLAGS changes there too would
> make sense too.
Yeah please do that patch ASAP, having PEBS behave differently across
uarchs is wrong.
next prev parent reply other threads:[~2014-09-10 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 0:49 [PATCH 1/2] perf, x86: Add INTEL_FLAGS_UEVENT_CONSTRAINT Andi Kleen
2014-09-10 0:49 ` [PATCH 2/2] perf, x86: Use INTEL_FLAGS_UEVENT_CONSTRAINT for PRECDIST Andi Kleen
2014-09-10 7:59 ` Peter Zijlstra
2014-09-10 7:59 ` Peter Zijlstra
2014-09-10 8:37 ` Stephane Eranian
2014-09-10 8:39 ` Peter Zijlstra
2014-09-10 14:02 ` Andi Kleen
2014-09-10 14:22 ` Peter Zijlstra [this message]
2014-09-23 9:58 ` Peter Zijlstra
2014-10-03 4:02 ` Ingo Molnar
2014-09-10 20:38 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910142232.GC4783@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox