Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

Al Viro
2014-09-10T19:20:58Z

On Wed, Sep 10, 2014 at 03:17:34PM -0400, J. Bruce Fields wrote:
> On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote:
> > Signed-off-by: Jeff Layton <jlayton@primarydata.com>
> > ---
> > fs/nfs/delegation.c | 37 +++++++++++++++++++++----------------
> > fs/nfs/nfs4state.c | 24 +++++++++++++++---------
> > fs/nfs/pagelist.c | 3 ++-
> > fs/nfs/write.c | 39 +++++++++++++++++++++++++++++++++------
> > 4 files changed, 71 insertions(+), 32 deletions(-)
> >
> > diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
> > index 5853f53db732..22c6eed9bb5b 100644
> > --- a/fs/nfs/delegation.c
> > +++ b/fs/nfs/delegation.c
> > @@ -85,25 +85,30 @@ static int nfs_delegation_claim_locks(struct nfs_open_context *ctx, struct nfs4_
> > {
> > struct inode *inode = state->inode;
> > struct file_lock *fl;
> > + struct file_lock_context *flctx = inode->i_flctx;

Ummm... Something ought to be done for inflicting identifiers like that on
those who'll read that code. But That Would Probably Be Illegal(tm), more's
the pity...