From: Gleb Natapov <gleb@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tang Chen <tangchen@cn.fujitsu.com>,
mtosatti@redhat.com, nadav.amit@gmail.com, jan.kiszka@web.de,
kvm@vger.kernel.org, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/7] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest().
Date: Thu, 11 Sep 2014 13:12:01 +0300 [thread overview]
Message-ID: <20140911101200.GF25317@minantech.com> (raw)
In-Reply-To: <541169AD.6060908@redhat.com>
On Thu, Sep 11, 2014 at 11:21:49AM +0200, Paolo Bonzini wrote:
> Il 11/09/2014 07:38, Tang Chen ha scritto:
> > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > index 63c4c3e..da6d55d 100644
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -7093,6 +7093,11 @@ static void vmx_set_virtual_x2apic_mode(struct kvm_vcpu *vcpu, bool set)
> > vmx_set_msr_bitmap(vcpu);
> > }
> >
> > +static void vmx_set_apic_access_page_addr(struct kvm *kvm, hpa_t hpa)
> > +{
> > + vmcs_write64(APIC_ACCESS_ADDR, hpa);
>
> This has to be guarded by "if (!is_guest_mode(vcpu))".
>
We do need to write it if L1 and L2 share APIC_ACCESS_ADDR and skip
it otherwise, no?
> > +}
> > +
--
Gleb.
next prev parent reply other threads:[~2014-09-11 10:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 5:37 [PATCH v5 0/7] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-09-11 5:38 ` [PATCH v5 1/7] kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address Tang Chen
2014-09-11 9:10 ` Paolo Bonzini
2014-09-11 5:38 ` [PATCH v5 2/7] kvm: Remove ept_identity_pagetable from struct kvm_arch Tang Chen
2014-09-11 9:14 ` Paolo Bonzini
2014-09-11 5:38 ` [PATCH v5 3/7] kvm: Make init_rmode_identity_map() return 0 on success Tang Chen
2014-09-11 9:17 ` Paolo Bonzini
2014-09-11 10:26 ` tangchen
2014-09-11 5:38 ` [PATCH v5 4/7] kvm, mem-hotplug: Reload L1' apic access page on migration in vcpu_enter_guest() Tang Chen
2014-09-11 9:21 ` Paolo Bonzini
2014-09-11 10:12 ` Gleb Natapov [this message]
2014-09-11 10:47 ` Paolo Bonzini
2014-09-11 11:30 ` Gleb Natapov
2014-09-11 13:05 ` Paolo Bonzini
2014-09-11 13:59 ` Gleb Natapov
2014-09-11 14:06 ` Paolo Bonzini
2014-09-11 14:21 ` Gleb Natapov
2014-09-11 14:24 ` Paolo Bonzini
2014-09-11 14:31 ` Gleb Natapov
2014-09-11 14:37 ` Paolo Bonzini
2014-09-11 14:47 ` Gleb Natapov
2014-09-12 3:32 ` tangchen
2014-09-12 3:36 ` tangchen
2014-09-11 10:20 ` tangchen
2014-09-11 10:39 ` Paolo Bonzini
2014-09-11 5:38 ` [PATCH v5 5/7] kvm, mem-hotplug: Reload L1's apic access page on migration when L2 is running Tang Chen
2014-09-11 9:28 ` Paolo Bonzini
2014-09-11 5:38 ` [PATCH v5 6/7] kvm, mem-hotplug: Unpin and remove kvm_arch->apic_access_page Tang Chen
2014-09-11 9:34 ` Paolo Bonzini
2014-09-11 5:38 ` [PATCH v5 7/7] kvm, mem-hotplug: Unpin and remove nested_vmx->apic_access_page Tang Chen
2014-09-11 9:33 ` Paolo Bonzini
2014-09-11 9:43 ` tangchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911101200.GF25317@minantech.com \
--to=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=pbonzini@redhat.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox