Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

Wolfram Sang
2014-09-11T11:35:47Z

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

> > This is a workaround. It would make sense, however, to add it because we
> > want to support i2c_board_info structures.
> >
>
> I think it really depends if an IP block can be used on non-DT platforms
> (which I think is true for this trackpad) but if a driver is for an IP block
> that can only be used on a DT-only platform (e.g: a PMIC that is controlled
> over I2C and is only compatible with a DT-only SoC) then I don't think we need
> to support the i2c_board_info structure and can get rid of the I2C ID table on
> these drivers once Lee series land.

That is exactly what I meant. It should be only added if there is a
reason other than "workaround". If you say, it doesn't make sense on
non-DT, then it should not be added.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]