From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756203AbaIKOu1 (ORCPT ); Thu, 11 Sep 2014 10:50:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11430 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbaIKOuX (ORCPT ); Thu, 11 Sep 2014 10:50:23 -0400 Date: Thu, 11 Sep 2014 15:47:38 +0100 From: Aaron Tomlin To: Chuck Ebbert Cc: peterz@infradead.org, mingo@redhat.com, dzickus@redhat.com, bmr@redhat.com, jcastillo@redhat.com, oleg@redhat.com, pzijlstr@redhat.com, riel@redhat.com, prarit@redhat.com, jgh@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, rostedt@goodmis.org, hannes@cmpxchg.org, aneesh.kumar@linux.vnet.ibm.com, akpm@linux-foundation.org, akpm@google.com, linuxppc-dev@lists.ozlabs.org, minchan@kernel.org Subject: Re: [PATCH v2 1/3] init/main.c: Give init_task a canary Message-ID: <20140911144738.GE12612@atomlin.usersys.redhat.com> References: <20140904161124.GD1436@atomlin.usersys.redhat.com> <1410255749-2956-1-git-send-email-atomlin@redhat.com> <1410255749-2956-2-git-send-email-atomlin@redhat.com> <20140910022654.29abc9f3@as> <20140910132933.GG1436@atomlin.usersys.redhat.com> <20140911072345.012f4ef3@as> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20140911072345.012f4ef3@as> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 11, 2014 at 07:23:45AM -0500, Chuck Ebbert wrote: > On Wed, 10 Sep 2014 14:29:33 +0100 > Aaron Tomlin wrote: > > > On Wed, Sep 10, 2014 at 02:26:54AM -0500, Chuck Ebbert wrote: > > > And has this been tested on parisc and metag, which use STACK_GROWSUP ? > > > I can't see how end_of_stack() as it's defined now could work on those archs. > > > > AFAIU, dup_task_struct() has always done this explicitly. > > I see no reason why init_task requires special attention. > > > > I guess what I'm saying is, I can't see how the stack canary could have ever > detected any problems on parisc and metag. How did you test your patches on x86? Yes - under x86 only. > Maybe someone could run tests on those other archs. As I said, I can't see why it wouldn't work given dup_task_struct()'s behaviour. -- Aaron Tomlin