From: Dan Carpenter <dan.carpenter@oracle.com>
To: micky_ching@realsil.com.cn
Cc: sameo@linux.intel.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
devel@linuxdriverproject.org, rogerable@realtek.com,
lee.jones@linaro.org
Subject: Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227
Date: Fri, 12 Sep 2014 11:36:27 +0300 [thread overview]
Message-ID: <20140912083627.GX6600@mwanda> (raw)
In-Reply-To: <20140911074249.GW6600@mwanda>
On Thu, Sep 11, 2014 at 10:42:49AM +0300, Dan Carpenter wrote:
> On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ching@realsil.com.cn wrote:
> > + err = pci_read_config_byte(pcr->pci, addr, &val);
> > + if (err)
> > + return err;
>
> Some of these check for "if (err) " and some check for "if (err < 0) ".
> What is the significance of that? I'm a newbie here. Did you mean for
> them to be different?
You've updated them all to be "if (err < 0)" how is that different from
"if (err)"? What I'm saying is that could you reply to the question?
I guess I normally prefer "if (err)" over "if (err < 0)" but I don't
know if it makes a difference here?
regards,
dan carpenter
>
next prev parent reply other threads:[~2014-09-12 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 7:17 [PATCH 0/2] mfd: rtsx: fix PM suspend for 5227 & 5249 micky_ching
2014-09-11 7:17 ` [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227 micky_ching
2014-09-11 7:42 ` Dan Carpenter
2014-09-12 8:36 ` Dan Carpenter [this message]
2014-09-12 8:43 ` micky
2014-09-11 7:17 ` [PATCH 2/2] mfd: rtsx: fix PM suspend for 5249 micky_ching
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912083627.GX6600@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox