Re: [RFC 0/4] i2c: slave support framework for Linux devices

Uwe Kleine-König
2014-09-12T08:58:45Z

Hello Wolfram,

On Tue, Sep 09, 2014 at 04:54:26PM +0200, Wolfram Sang wrote:
> Finally, here is my take on the often desired feature that Linux can not only
> be an I2C master, but also an I2C slave. Compared to my draft sent out last
> week, this RFC has been tested on hardware (Renesas Lager board) and works \o/
>
> One big part still missing is documentation, so brave ones need to "use the
> source". However, this approach turned out to be even less intrusive than
> expected, so that is hopefully a good sign.
Some thoughts from reading through your patch set:

- If I understand correctly you cannot register an i2c slave without
also registering a master, right? I don't think this is troubling in
practice, is it?
For abstraction I would prefer to make these different concepts
though.

- The IMHO most (even only?) useful slave is "i2cslvdev", i.e. a
userspace device. With that you wouldn't need device tree stuff, the
driver would just offer the device if supported. Userspace then could
care about the rest (slave address, functionality, ...).

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |