From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>,
Michal Simek <monstr@monstr.eu>,
Rob Herring <rob.herring@calxeda.com>,
Paul Bolle <pebolle@tiscali.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mikael Starvik <starvik@axis.com>,
Jesper Nilsson <jespern@axis.com>
Subject: Re: [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break
Date: Mon, 15 Sep 2014 10:50:29 +0200 [thread overview]
Message-ID: <20140915085029.GY4659@axis.com> (raw)
In-Reply-To: <CAMuHMdU6adYoOafUZ2STZCeuQa3cU-_kD7FHW3x=Tq-O+aqrZw@mail.gmail.com>
On Sun, Sep 14, 2014 at 10:45:23AM +0200, Geert Uytterhoeven wrote:
> Hi Chen,
>
> On Sun, Sep 14, 2014 at 10:32 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> > Add default one just like other architectures have done (e.g. cris,
> > score, sh ...), the related error with allmodconfig:
> >
> > LD init/built-in.o
> > drivers/built-in.o: In function `vgacon_save_screen':
> > drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to `screen_info'
> > drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to `screen_info'
> > drivers/built-in.o: In function `vgacon_resize':
> > drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to `screen_info'
> > drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to `screen_info'
> > drivers/built-in.o: In function `vgacon_switch':
> > drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to `screen_info'
> > drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to `screen_info' follow
> > make: *** [vmlinux] Error 1
>
> Can microblaze actually have VGA?
>
> If not, it's better to disable it.
>
> BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS
> in drivers/video/console/Kconfig...
No CRIS platform has ever had a video console.
> I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make
> VGA_CONSOLE depend on that, cfr.
Sounds reasonable, at least it can avoid the specific depends on !*arch* cruft.
> Gr{oetje,eeting}s,
>
> Geert
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2014-09-15 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 8:32 [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break Chen Gang
2014-09-14 8:45 ` Geert Uytterhoeven
2014-09-14 9:02 ` Chen Gang
2014-09-16 9:23 ` Michal Simek
2014-09-16 10:04 ` Geert Uytterhoeven
2014-09-16 10:59 ` Michal Simek
2014-09-16 14:34 ` Chen Gang
2014-09-15 8:50 ` Jesper Nilsson [this message]
2014-09-15 11:10 ` Chen Gang
2014-09-20 4:08 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915085029.GY4659@axis.com \
--to=jesper.nilsson@axis.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jespern@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=pebolle@tiscali.nl \
--cc=rob.herring@calxeda.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).